chrome/browser/speech/extension_api/tts_engine_extension_observer.h - Issue 661423008: Standardize usage of virtual/override/final in chrome/browser/speech

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/speech/extension_api/tts_engine_extension_observer.h

Issue 661423008: Standardize usage of virtual/override/final in chrome/browser/speech (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/speech/extension_api/tts_engine_extension_api.h ('k') | chrome/browser/speech/extension_api/tts_engine_extension_observer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/speech/extension_api/tts_engine_extension_observer.h

diff --git a/chrome/browser/speech/extension_api/tts_engine_extension_observer.h b/chrome/browser/speech/extension_api/tts_engine_extension_observer.h

index 2b0dd385d13d0a078da0e5ed296abb2d665844fd..08d38c21ad910b1f7d0bdcac56e0510f5a2ef37a 100644

--- a/chrome/browser/speech/extension_api/tts_engine_extension_observer.h

+++ b/chrome/browser/speech/extension_api/tts_engine_extension_observer.h

@@ -27,21 +27,20 @@ class TtsEngineExtensionObserver

bool SawExtensionLoad(const std::string& extension_id, bool update);

// Implementation of KeyedService.

- virtual void Shutdown() override;

+ void Shutdown() override;

// Implementation of extensions::EventRouter::Observer.

- virtual void OnListenerAdded(

- const extensions::EventListenerInfo& details) override;

+ void OnListenerAdded(const extensions::EventListenerInfo& details) override;

// extensions::ExtensionRegistryObserver overrides.

- virtual void OnExtensionUnloaded(

+ void OnExtensionUnloaded(

content::BrowserContext* browser_context,

const extensions::Extension* extension,

extensions::UnloadedExtensionInfo::Reason reason) override;

private:

explicit TtsEngineExtensionObserver(Profile* profile);

- virtual ~TtsEngineExtensionObserver();

+ ~TtsEngineExtensionObserver() override;

bool IsLoadedTtsEngine(const std::string& extension_id);