Make 'git cl patch' work when not on a named branch.

Make 'git cl patch' work when not on a named branch.

R=maruel@chromium.org,pgervais@chromium.org
BUG=

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=292537

[M-A Ruel, 2014-10-20 20:43:34]

That's not a use case I had expected but 'ok'.

lgtm

[pgervais, 2014-10-20 20:45:57]

I have one nit.

https://codereview.chromium.org/661413005/diff/1/git_cl.py
File git_cl.py (right):

https://codereview.chromium.org/661413005/diff/1/git_cl.py#newcode532
git_cl.py:532: self.branchref = branchref
Please define self.branchref in __init__.

[pgervais, 2014-10-20 20:46:51]

I'm also wondering whether this could have side-effects on bots.

[szager1, 2014-10-20 20:55:58]

On 2014/10/20 20:43:34, M-A Ruel wrote:
> That's not a use case I had expected but 'ok'.

Hmm, doesn't seem so weird to me.  I'm reviewing a patch, and I want to apply it
locally to try out.  Why should I be on named branch?  I just: 'git checkout
origin/master && git cl patch 123456'

[szager1, 2014-10-20 22:29:52]

https://codereview.chromium.org/661413005/diff/1/git_cl.py
File git_cl.py (right):

https://codereview.chromium.org/661413005/diff/1/git_cl.py#newcode532
git_cl.py:532: self.branchref = branchref
On 2014/10/20 20:45:57, pgervais wrote:
> Please define self.branchref in __init__. 

It already is.

[szager1, 2014-10-20 22:30:15]

The CQ bit was checked by szager@chromium.org

[commit-bot: I haz the power, 2014-10-20 22:31:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/661413005/1

[commit-bot: I haz the power, 2014-10-20 22:33:23]

Committed patchset #1 (id:1) as 292537