Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Issue 661413003: Android: add support for Device Orientation on devices where ROTATION_VECTOR is not availabl… (Closed)

Created:
6 years, 2 months ago by timvolodine
Modified:
6 years, 1 month ago
CC:
chromium-reviews, jar (doing other things), jam, timvolodine, joi+watch-content_chromium.org, darin-cc_chromium.org, asvitkine+watch_chromium.org, Michael van Ouwerkerk
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Android: add support for Device Orientation on devices where ROTATION_VECTOR is not available. BUG=347507 Committed: https://crrev.com/11d2aa96d1869d0ff47a7e7bf0ae15a4c90c0bff Cr-Commit-Position: refs/heads/master@{#300985}

Patch Set 1 #

Patch Set 2 : more debugging #

Patch Set 3 : remove logging, clean-up fix tests #

Patch Set 4 : add test when rotation vector is not available #

Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -17 lines) Patch
M content/browser/device_sensors/sensor_manager_android.h View 1 2 chunks +3 lines, -0 lines 0 comments Download
M content/browser/device_sensors/sensor_manager_android.cc View 1 2 4 chunks +11 lines, -2 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/DeviceSensors.java View 1 2 10 chunks +57 lines, -6 lines 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/DeviceSensorsTest.java View 1 2 3 6 chunks +36 lines, -9 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
timvolodine
6 years, 1 month ago (2014-10-22 11:36:53 UTC) #2
Michael van Ouwerkerk
lgtm
6 years, 1 month ago (2014-10-22 14:16:32 UTC) #3
timvolodine
thanks Michael, I've also added a test for this now.
6 years, 1 month ago (2014-10-22 16:43:50 UTC) #4
Michael van Ouwerkerk
Thanks Tim. Still lgtm
6 years, 1 month ago (2014-10-22 16:57:10 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/661413003/60001
6 years, 1 month ago (2014-10-23 12:34:13 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu_triggered_tests/builds/71861)
6 years, 1 month ago (2014-10-23 13:16:56 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/661413003/60001
6 years, 1 month ago (2014-10-23 23:15:32 UTC) #11
commit-bot: I haz the power
Committed patchset #4 (id:60001)
6 years, 1 month ago (2014-10-23 23:42:32 UTC) #12
commit-bot: I haz the power
6 years, 1 month ago (2014-10-23 23:43:00 UTC) #13
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/11d2aa96d1869d0ff47a7e7bf0ae15a4c90c0bff
Cr-Commit-Position: refs/heads/master@{#300985}

Powered by Google App Engine
This is Rietveld 408576698