Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 661393005: Accessible name of text fields on Android should prefer field value (Closed)

Created:
6 years, 2 months ago by dmazzoni
Modified:
6 years, 2 months ago
CC:
chromium-reviews, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, jam, yuzo+watch_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@scroll_to_make_visible
Project:
chromium
Visibility:
Public.

Description

Accessible name of text fields on Android should prefer field value On Android, each object can only have a single accessible text string associated with it - so a text field can't simultaneously have a name and a value. Have it always return the value if nonempty, and the name/label otherwise. BUG=425310 Committed: https://crrev.com/67d42382e20617f55255a8024992cb040f691f4b Cr-Commit-Position: refs/heads/master@{#300389}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Remove extra line on win #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -8 lines) Patch
M content/browser/accessibility/browser_accessibility_android.cc View 1 chunk +15 lines, -4 lines 0 comments Download
M content/browser/accessibility/dump_accessibility_tree_browsertest.cc View 1 chunk +4 lines, -0 lines 0 comments Download
A content/test/data/accessibility/input-text-value.html View 1 chunk +23 lines, -0 lines 0 comments Download
A + content/test/data/accessibility/input-text-value-expected-android.txt View 1 chunk +10 lines, -6 lines 0 comments Download
A + content/test/data/accessibility/input-text-value-expected-mac.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + content/test/data/accessibility/input-text-value-expected-win.txt View 1 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
dmazzoni
Peter or Alice, whoever has a chance first?
6 years, 2 months ago (2014-10-20 22:06:51 UTC) #2
aboxhall
lgtm https://codereview.chromium.org/661393005/diff/1/content/test/data/accessibility/input-text-value-expected-win.txt File content/test/data/accessibility/input-text-value-expected-win.txt (right): https://codereview.chromium.org/661393005/diff/1/content/test/data/accessibility/input-text-value-expected-win.txt#newcode2 content/test/data/accessibility/input-text-value-expected-win.txt:2: Weird extra line?
6 years, 2 months ago (2014-10-20 22:19:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/661393005/20001
6 years, 2 months ago (2014-10-20 22:24:51 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 2 months ago (2014-10-21 00:34:31 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-21 00:35:09 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/67d42382e20617f55255a8024992cb040f691f4b
Cr-Commit-Position: refs/heads/master@{#300389}

Powered by Google App Engine
This is Rietveld 408576698