[fsp] Separate logic for saving/restoring state to a separate class.

[fsp] Separate logic for saving/restoring state to a separate class.

Previously, the Service class was responsible for saving and restoring state,
as well as managing file systems. Testing it became problematic.

This patch separates it into two classes Service and Registry, which can
be both tested separately.

TBR=pam@chromium.org
TEST=unit_tests: *FileSystemProvider*Registry*
BUG=248427
Committed: https://crrev.com/bd1170f84cdcc4b1601a414ee68702d8e9361849
Cr-Commit-Position: refs/heads/master@{#300422}

[mtomasz, 2014-10-20 05:37:43]

https://codereview.chromium.org/661393002/diff/1/chrome/browser/chromeos/file...
File chrome/browser/chromeos/file_system_provider/provided_file_system_info.h
(left):

https://codereview.chromium.org/661393002/diff/1/chrome/browser/chromeos/file...
chrome/browser/chromeos/file_system_provider/provided_file_system_info.h:23:
std::string extension_id;
(This was unused.)

https://codereview.chromium.org/661393002/diff/1/chrome/browser/chromeos/file...
File chrome/browser/chromeos/file_system_provider/registry.cc (right):

https://codereview.chromium.org/661393002/diff/1/chrome/browser/chromeos/file...
chrome/browser/chromeos/file_system_provider/registry.cc:1: // Copyright 2014
The Chromium Authors. All rights reserved.
(Most of the file is moved from service.cc.)

https://codereview.chromium.org/661393002/diff/1/chrome/browser/chromeos/file...
File chrome/browser/chromeos/file_system_provider/registry_unittest.cc (right):

https://codereview.chromium.org/661393002/diff/1/chrome/browser/chromeos/file...
chrome/browser/chromeos/file_system_provider/registry_unittest.cc:1: //
Copyright 2014 The Chromium Authors. All rights reserved.
(Mostly moved from service_unittest.cc.)

[mtomasz, 2014-10-20 05:37:53]

mtomasz@chromium.org changed reviewers:
+ fukino@chromium.org

[mtomasz, 2014-10-20 05:38:23]

@fukino: PTAL. Thanks! It's mostly a mechanical change - moving code from
service_* to registry_*.

[fukino, 2014-10-20 09:42:05]

LGTM! But I have a question.

https://codereview.chromium.org/661393002/diff/1/chrome/browser/chromeos/file...
File chrome/browser/chromeos/file_system_provider/service.cc (right):

https://codereview.chromium.org/661393002/diff/1/chrome/browser/chromeos/file...
chrome/browser/chromeos/file_system_provider/service.cc:295: for
(RegistryInterface::RestoredFileSystems::const_iterator it =
According to http://chromium-cpp.appspot.com/ we may use auto.
For new code, should we use those features? or should we stick to current style
for consistency?

[mtomasz, 2014-10-21 02:22:20]

https://codereview.chromium.org/661393002/diff/1/chrome/browser/chromeos/file...
File chrome/browser/chromeos/file_system_provider/service.cc (right):

https://codereview.chromium.org/661393002/diff/1/chrome/browser/chromeos/file...
chrome/browser/chromeos/file_system_provider/service.cc:295: for
(RegistryInterface::RestoredFileSystems::const_iterator it =
On 2014/10/20 09:42:04, fukino wrote:
> According to http://chromium-cpp.appspot.com/ we may use auto.
> For new code, should we use those features? or should we stick to current
style
> for consistency?

Good point! Done. For consistency I'll update the entire FSP code in a separate
patch.

[mtomasz, 2014-10-21 02:23:39]

mtomasz@chromium.org changed reviewers:
+ pam@chromium.org

[mtomasz, 2014-10-21 02:23:55]

@pam: PTAL at chrome/browser/prefs/browser_prefs.cc. TBR since a trivial change.

[mtomasz, 2014-10-21 04:49:06]

@fukino: I introduced auto. PTAL at the changes. Thanks!

[fukino, 2014-10-21 04:56:15]

On 2014/10/21 04:49:06, mtomasz wrote:
> @fukino: I introduced auto. PTAL at the changes. Thanks!

lgtm!

[mtomasz, 2014-10-21 04:57:37]

The CQ bit was checked by mtomasz@chromium.org

[commit-bot: I haz the power, 2014-10-21 04:57:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/661393002/20001

[commit-bot: I haz the power, 2014-10-21 05:34:30]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2014-10-21 05:35:30]

Patchset 2 (id:??) landed as
https://crrev.com/bd1170f84cdcc4b1601a414ee68702d8e9361849
Cr-Commit-Position: refs/heads/master@{#300422}