Vboot Reference: Refactor Code.

src/platform/vboot_reference/utils/verify_data.c

 /* Copyright (c) 2010 The Chromium OS Authors. All rights reserved.
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 /* Routines for verifying a file's signature. Useful in testing the core
  * RSA verification implementation.
  */
 
 #include <fcntl.h>
@@ skipping 56 matching lines @@
       fprintf(stderr, "\t%d for %s\n", i, algo_strings[i]);
     return -1;
   }
 
   algorithm = atoi(argv[1]);
   if (algorithm >= kNumAlgorithms) {
     fprintf(stderr, "Invalid Algorithm!\n");
     return 0;
   }
   /* Length of the RSA Signature/RSA Key */
-  sig_len = siglen_map[algorithm]; 
-  if (!(key = RSAPublicKeyFromFile(argv[2])))
-    goto failure;
-  if (!(signature = read_signature(argv[3], sig_len)))
-    goto failure;
-  if (!(digest = DigestFile(argv[4], algorithm)))
-    goto failure;
-  if(RSA_verify(key, signature, sig_len, algorithm, digest)) {
-    return_code = 0;
-    fprintf(stderr, "Signature Verification "
-            COL_GREEN "SUCCEEDED" COL_STOP "\n");
-  } else {
-    fprintf(stderr, "Signature Verification "
-            COL_RED "FAILED" COL_STOP "\n");
+  sig_len = siglen_map[algorithm];
+  if ((key = RSAPublicKeyFromFile(argv[2])) &&
+      (signature = read_signature(argv[3], sig_len)) &&
+      (digest = DigestFile(argv[4], algorithm))) {
+    if (RSAVerify(key, signature, sig_len, algorithm, digest)) {
+      return_code = 0;
+      fprintf(stderr, "Signature Verification "
+              COL_GREEN "SUCCEEDED" COL_STOP "\n");
+    } else {
+      fprintf(stderr, "Signature Verification "
+              COL_RED "FAILED" COL_STOP "\n");
+    }
   }
+  else
+    return_code = -1;
 
-failure:
   free(key);
   free(signature);
   free(digest);
 
   return return_code;
 }