Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/test/pyautolib/pyautolib.cc

Issue 661342: Build pyauto on win (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: using subprocess.call() Created 10 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/pyautolib/pyautolib.h ('k') | chrome/test/pyautolib/pyautolib.i » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/pyautolib/pyautolib.cc
===================================================================
--- chrome/test/pyautolib/pyautolib.cc (revision 40643)
+++ chrome/test/pyautolib/pyautolib.cc (working copy)
@@ -98,14 +98,14 @@
return is_visible;
}
-std::string PyUITestSuite::GetDownloadDirectory() {
+FilePath PyUITestSuite::GetDownloadDirectory() {
FilePath download_dir;
scoped_refptr<TabProxy> tab_proxy(GetActiveTab());
EXPECT_TRUE(tab_proxy.get());
if (!tab_proxy.get())
- return download_dir.value();
+ return download_dir;
EXPECT_TRUE(tab_proxy->GetDownloadDirectory(&download_dir));
- return download_dir.value();
+ return download_dir;
}
bool PyUITestSuite::OpenNewBrowserWindow(bool show) {
« no previous file with comments | « chrome/test/pyautolib/pyautolib.h ('k') | chrome/test/pyautolib/pyautolib.i » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698