Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(362)

Issue 661342: Build pyauto on win (Closed)

Created:
10 years, 9 months ago by Nirnimesh
Modified:
9 years, 7 months ago
Reviewers:
John Grabowski
CC:
chromium-reviews, pam+watch_chromium.org
Visibility:
Public.

Description

- Update README.chromium to mention change to swig libs in third_party - Provide platform-specific macros to swig. - Update DEPS to use right swig updates To be committed _after_ accompanying CL: http://codereview.chromium.org/661334 BUG=32285 TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=41048

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Patch Set 6 : '' #

Total comments: 7

Patch Set 7 : '' #

Total comments: 4

Patch Set 8 : '' #

Patch Set 9 : Fixed path on win #

Patch Set 10 : '' #

Total comments: 2

Patch Set 11 : using subprocess.call() #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -29 lines) Patch
M DEPS View 5 6 7 8 9 10 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_tests.gypi View 4 5 6 7 8 9 10 3 chunks +17 lines, -5 lines 0 comments Download
M chrome/test/pyautolib/pyautolib.h View 4 5 6 7 8 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/pyautolib/pyautolib.cc View 4 5 6 7 8 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/test/pyautolib/pyautolib.i View 4 5 6 7 8 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/swig/README.chromium View 1 2 3 4 5 6 7 8 1 chunk +17 lines, -15 lines 0 comments Download
M tools/swig/swig.py View 1 2 3 4 5 6 7 8 9 10 2 chunks +12 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
John Grabowski
http://codereview.chromium.org/661342/diff/32/1018 File chrome/chrome_tests.gypi (right): http://codereview.chromium.org/661342/diff/32/1018#newcode1866 chrome/chrome_tests.gypi:1866: ['(OS!="linux" or target_arch!="x64" or linux_fpic==1) and ' Ugh. Make ...
10 years, 9 months ago (2010-03-02 06:00:06 UTC) #1
Nirnimesh
The try bots have an issue with patching this CL. I won't commit until I ...
10 years, 9 months ago (2010-03-02 23:50:22 UTC) #2
John Grabowski
LGTM if you promise to deal with the Windows py2.4 --> py2.5 thing. http://codereview.chromium.org/661342/diff/32/1018 File ...
10 years, 9 months ago (2010-03-03 00:14:07 UTC) #3
Nirnimesh
John, I didn't check this in following breakages with the try-bot and me fighting with ...
10 years, 9 months ago (2010-03-08 22:40:46 UTC) #4
John Grabowski
http://codereview.chromium.org/661342/diff/5001/5002 File tools/swig/swig.py (right): http://codereview.chromium.org/661342/diff/5001/5002#newcode40 tools/swig/swig.py:40: os.system(cmd) subprocess module replaces os.system
10 years, 9 months ago (2010-03-09 00:27:39 UTC) #5
Nirnimesh
10 years, 9 months ago (2010-03-09 07:56:33 UTC) #6
Thanks for reviewing even while you're away, John.

http://codereview.chromium.org/661342/diff/5001/5002
File tools/swig/swig.py (right):

http://codereview.chromium.org/661342/diff/5001/5002#newcode40
tools/swig/swig.py:40: os.system(cmd)
On 2010/03/09 00:27:39, John Grabowski wrote:
> subprocess module replaces os.system

Done.

Powered by Google App Engine
This is Rietveld 408576698