Web MIDI: use new Blink APIs to be free from depracated ones

Web MIDI: use new Blink APIs to be free from depracated ones

This is the second step to update the Blink APIs.
To remove old Blink APIs that do not have isActive flag,
update all callers to specify the isActive flag.

The first change to add the new Blink APIs is
https://codereview.chromium.org/649683006/

BUG=279097
TBR=scherkus@chromium.org

Committed: https://crrev.com/3dcb475f8fbe8b866657cd577a7c5efdddc8c94d
Cr-Commit-Position: refs/heads/master@{#300276}

[Takashi Toyoshima, 2014-10-20 05:48:14]

toyoshim@chromium.org changed reviewers:
+ scherkus@chromium.org, tkent@chromium.org

[Takashi Toyoshima, 2014-10-20 05:48:14]

scherkus@chromium.org: Please review changes in content/renderer/media/
tkent@chromium.org: Please review changes in content/shell/test_runner/

The first CL to update the API in blink side is
https://codereview.chromium.org/649683006/.

[tkent, 2014-10-20 05:59:33]

https://codereview.chromium.org/661323002/diff/1/content/shell/renderer/test_...
File content/shell/renderer/test_runner/mock_web_midi_accessor.cc (right):

https://codereview.chromium.org/661323002/diff/1/content/shell/renderer/test_...
content/shell/renderer/test_runner/mock_web_midi_accessor.cc:53: true);
literal bool argument is not good for code readability.
If we'll add more literal bool for this argument , we should change the argument
an enum. Otherwise, please add a code comment or a constant symbol.  e.g.
   didAddInputPort(...., true /* active */);

   const bool active = true;
   didAddInputPort(..., active);

[Takashi Toyoshima, 2014-10-20 06:41:29]

https://codereview.chromium.org/661323002/diff/1/content/shell/renderer/test_...
File content/shell/renderer/test_runner/mock_web_midi_accessor.cc (right):

https://codereview.chromium.org/661323002/diff/1/content/shell/renderer/test_...
content/shell/renderer/test_runner/mock_web_midi_accessor.cc:53: true);
On 2014/10/20 05:59:33, tkent wrote:
> literal bool argument is not good for code readability.
> If we'll add more literal bool for this argument , we should change the
argument
> an enum. Otherwise, please add a code comment or a constant symbol.  e.g.
>    didAddInputPort(...., true /* active */);
> 
>    const bool active = true;
>    didAddInputPort(..., active);

Done.

https://codereview.chromium.org/661323002/diff/20001/content/renderer/media/m...
File content/renderer/media/midi_message_filter.cc (right):

https://codereview.chromium.org/661323002/diff/20001/content/renderer/media/m...
content/renderer/media/midi_message_filter.cc:124: const bool active = true;
did the same fix here.

[tkent, 2014-10-20 06:52:16]

lgtm

[Takashi Toyoshima, 2014-10-20 12:21:36]

I will land this once blink r183974 is rolled.

[Takashi Toyoshima, 2014-10-20 15:45:48]

The CQ bit was checked by toyoshim@chromium.org

[commit-bot: I haz the power, 2014-10-20 15:47:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/661323002/20001

[commit-bot: I haz the power, 2014-10-20 16:36:13]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2014-10-20 16:37:23]

Patchset 2 (id:??) landed as
https://crrev.com/3dcb475f8fbe8b866657cd577a7c5efdddc8c94d
Cr-Commit-Position: refs/heads/master@{#300276}

[scherkus (not reviewing), 2014-10-20 18:11:39]

lgtm