Issue 66123002: fix angular sample

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 66123002: fix angular sample (Closed)

Created:
7 years, 1 month ago by danrubel

Modified:
7 years, 1 month ago

Reviewers:
dgrove, Jennifer Messerly

CC:
reviews_dartlang.org, Anders Johnsen

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

fix angular sample * adjust the pubspec versions so that the sample runs again * modify code to remove warning R=jmesserly@google.com Committed: https://code.google.com/p/dart/source/detail?r=30095

Patch Set 1 #

Total comments: 2

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -4 lines)			Patch
	M	samples/third_party/angular_todo/pubspec.yaml	View		1 chunk	+4 lines, -4 lines	0 comments	Download
	M	samples/third_party/angular_todo/todo.dart	View		1 chunk	+1 line, -0 lines	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Jennifer Messerly

lgtm https://codereview.chromium.org/66123002/diff/1/samples/third_party/angular_todo/todo.dart File samples/third_party/angular_todo/todo.dart (right): https://codereview.chromium.org/66123002/diff/1/samples/third_party/angular_todo/todo.dart#newcode40 samples/third_party/angular_todo/todo.dart:40: Http _http; upstream this fix?

7 years, 1 month ago (2013-11-08 01:54:02 UTC) #2

danrubel

https://codereview.chromium.org/66123002/diff/1/samples/third_party/angular_todo/todo.dart File samples/third_party/angular_todo/todo.dart (right): https://codereview.chromium.org/66123002/diff/1/samples/third_party/angular_todo/todo.dart#newcode40 samples/third_party/angular_todo/todo.dart:40: Http _http; On 2013/11/08 01:54:02, John Messerly wrote: > ...

7 years, 1 month ago (2013-11-08 01:55:34 UTC) #3

danrubel

7 years, 1 month ago (2013-11-08 01:56:54 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r30095 (presubmit successful).

Expand Messages | Collapse Messages