Issue 661213002: Don't shadow variables (same name in scope)

Issue 661213002: Don't shadow variables (same name in scope) (Closed)

Created:
6 years, 2 months ago by cpu_(ooo_6.6-7.5)

Modified:
6 years, 2 months ago

Reviewers:
danakj

CC:
chromium-reviews, erikwright+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git/+/master

Project:
chromium

Visibility:
Public.

Don't shadow variables (same name in scope) Specially being both locks. BUG=none Committed: https://crrev.com/8e0e50c08bf16ce9b6729d1cbc1975e00274c829 Cr-Commit-Position: refs/heads/master@{#300387}

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	base/threading/watchdog.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 11 (3 generated)

danakj

On 2014/10/20 22:02:14, danakj wrote: > LGTM Just remove the BUG= line from the commit ...

6 years, 2 months ago (2014-10-20 22:03:01 UTC) #7

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/661213002/1

6 years, 2 months ago (2014-10-20 23:19:31 UTC) #9

commit-bot: I haz the power

6 years, 2 months ago (2014-10-21 00:26:10 UTC) #11

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/8e0e50c08bf16ce9b6729d1cbc1975e00274c829
Cr-Commit-Position: refs/heads/master@{#300387}