tools/skp/recreate_skps.py - Issue 661203002: Fix RecreateSKPs bot (again)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/skp/recreate_skps.py

Issue 661203002: Fix RecreateSKPs bot (again) (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/skp/recreate_skps.py

diff --git a/tools/skp/recreate_skps.py b/tools/skp/recreate_skps.py

index 78863183cb90674e2e00a89bcd66476cd62aa860..bbec14a6a6c75b04c668282499927f5e7287f1d5 100644

--- a/tools/skp/recreate_skps.py

+++ b/tools/skp/recreate_skps.py

@@ -72,7 +72,7 @@ def main(chrome_src_path, browser_executable):

for line in procs.splitlines():

if browser_executable in line:

pid = line.strip().split(' ')[0]

- if pid != str(os.getpid()):

+ if pid != str(os.getpid()) and not 'python' in line:

try:

shell_utils.run(['kill', '-9', pid])

except shell_utils.CommandFailedException as e:

« no previous file with comments | « no previous file | no next file » | no next file with comments »