Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(428)

Unified Diff: media/cast/test/utility/tap_proxy.cc

Issue 661163004: Standardize usage of virtual/override/final specifiers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/cast/test/end2end_unittest.cc ('k') | media/ffmpeg/ffmpeg_common_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/cast/test/utility/tap_proxy.cc
diff --git a/media/cast/test/utility/tap_proxy.cc b/media/cast/test/utility/tap_proxy.cc
index 054687411174d737f13e986f42e8d1f9135ea0a2..eac758963ef8cef8a88670d0ad003b995faecd30 100644
--- a/media/cast/test/utility/tap_proxy.cc
+++ b/media/cast/test/utility/tap_proxy.cc
@@ -41,7 +41,7 @@ class SendToFDPipe : public PacketPipe {
public:
explicit SendToFDPipe(int fd) : fd_(fd) {
}
- virtual void Send(scoped_ptr<Packet> packet) override {
+ void Send(scoped_ptr<Packet> packet) override {
while (1) {
int written = write(
fd_,
@@ -85,11 +85,10 @@ class QueueManager : public base::MessageLoopForIO::Watcher {
&tick_clock_);
}
- virtual ~QueueManager() {
- }
+ ~QueueManager() override {}
// MessageLoopForIO::Watcher methods
- virtual void OnFileCanReadWithoutBlocking(int fd) override {
+ void OnFileCanReadWithoutBlocking(int fd) override {
scoped_ptr<Packet> packet(new Packet(kMaxPacketSize));
int nread = read(input_fd_,
reinterpret_cast<char*>(&packet->front()),
@@ -103,9 +102,7 @@ class QueueManager : public base::MessageLoopForIO::Watcher {
packet->resize(nread);
packet_pipe_->Send(packet.Pass());
}
- virtual void OnFileCanWriteWithoutBlocking(int fd) override {
- NOTREACHED();
- }
+ void OnFileCanWriteWithoutBlocking(int fd) override { NOTREACHED(); }
private:
int input_fd_;
@@ -172,8 +169,7 @@ ByteCounter out_pipe_output_counter;
class ByteCounterPipe : public media::cast::test::PacketPipe {
public:
ByteCounterPipe(ByteCounter* counter) : counter_(counter) {}
- virtual void Send(scoped_ptr<media::cast::Packet> packet)
- override {
+ void Send(scoped_ptr<media::cast::Packet> packet) override {
counter_->Increment(packet->size());
pipe_->Send(packet.Pass());
}
« no previous file with comments | « media/cast/test/end2end_unittest.cc ('k') | media/ffmpeg/ffmpeg_common_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698