tools/perf/page_sets/PRESUBMIT.py - Issue 661163002: Look in partner bucket while uploading .sha1 files.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/page_sets/PRESUBMIT.py

Issue 661163002: Look in partner bucket while uploading .sha1 files. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/perf/page_sets/PRESUBMIT.py

diff --git a/tools/perf/page_sets/PRESUBMIT.py b/tools/perf/page_sets/PRESUBMIT.py

index cf39ca1fcc2a0289acaec45819573b9ca89a5029..366f998876a28f9e448149b893b90b32ffc47160 100644

--- a/tools/perf/page_sets/PRESUBMIT.py

+++ b/tools/perf/page_sets/PRESUBMIT.py

@@ -39,10 +39,11 @@ def _GetFilesNotInCloud(input_api):

cloud_storage = LoadSupport(input_api)

- # Look in both buckets, in case the user uploaded the file manually. But this

+ # Look in all buckets, in case the user uploaded the file manually. But this

# script focuses on WPR archives, so it only uploads to the internal bucket.

hashes_in_cloud_storage = cloud_storage.List(cloud_storage.PUBLIC_BUCKET)

try:

+ hashes_in_cloud_storage += cloud_storage.List(cloud_storage.PARTNER_BUCKET)

hashes_in_cloud_storage += cloud_storage.List(cloud_storage.INTERNAL_BUCKET)

except (cloud_storage.PermissionError, cloud_storage.CredentialsError):

pass

« no previous file with comments | « no previous file | no next file » | no next file with comments »