Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(742)

Issue 661153003: Roll to Checkstyle 5.9 and enable Indentation check. (Closed)

Created:
6 years, 2 months ago by aurimas (slooooooooow)
Modified:
6 years, 2 months ago
Reviewers:
Yaron
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Roll to Checkstyle 5.9 and enable Indentation check. Release notes for Checkstyle 5.9 http://checkstyle.sourceforge.net/releasenotes.html The most important part is all the fixes for Indentation check that allows us to finally enable it for presubmit. Also adding OWNERS file to checkstyle directory. BUG=318404 TBR=yfriedman@chromium.org Committed: https://crrev.com/d1b316d5d0d00ce62b4d13dd7cda0e8930e55e09 Cr-Commit-Position: refs/heads/master@{#300353}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M third_party/checkstyle/README.chromium View 2 chunks +3 lines, -3 lines 0 comments Download
D third_party/checkstyle/checkstyle-5.8-all.jar View Binary file 0 comments Download
A + third_party/checkstyle/checkstyle-5.9-all.jar View Binary file 0 comments Download
A + tools/android/checkstyle/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
M tools/android/checkstyle/checkstyle.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/android/checkstyle/chromium-style-5.0.xml View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
aurimas (slooooooooow)
Hey Yaron, PTAL. Aurimas
6 years, 2 months ago (2014-10-17 21:52:13 UTC) #2
Yaron
On 2014/10/17 21:52:13, aurimas wrote: > Hey Yaron, > > PTAL. > > Aurimas does ...
6 years, 2 months ago (2014-10-20 20:22:54 UTC) #3
aurimas (slooooooooow)
On 2014/10/20 20:22:54, Yaron wrote: > On 2014/10/17 21:52:13, aurimas wrote: > > Hey Yaron, ...
6 years, 2 months ago (2014-10-20 20:32:37 UTC) #4
Yaron
Lgtm On Mon, Oct 20, 2014, 1:32 PM null <aurimas@chromium.org> wrote: > On 2014/10/20 20:22:54, ...
6 years, 2 months ago (2014-10-20 20:51:01 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/661153003/1
6 years, 2 months ago (2014-10-20 20:52:55 UTC) #7
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 2 months ago (2014-10-20 20:52:57 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/661153003/1
6 years, 2 months ago (2014-10-20 21:05:38 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-20 22:22:51 UTC) #12
commit-bot: I haz the power
6 years, 2 months ago (2014-10-20 22:24:00 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d1b316d5d0d00ce62b4d13dd7cda0e8930e55e09
Cr-Commit-Position: refs/heads/master@{#300353}

Powered by Google App Engine
This is Rietveld 408576698