LayoutTests/http/tests/misc/image-load-outlives-gc-without-crashing.html - Issue 66113002: Partial revert of r161493.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/http/tests/misc/image-load-outlives-gc-without-crashing.html

Issue 66113002: Partial revert of r161493. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: merge to ToT Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « LayoutTests/http/tests/misc/image-input-type-outlives-gc-without-crashing.html ('k') | LayoutTests/http/tests/misc/object-image-load-outlives-gc-without-crashing.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <script src="/js-test-resources/js-test.js"></script>	1 <script src="/js-test-resources/js-test.js"></script>

2 <script>	2 <script>

3	3

4 if (window.testRunner) {	4 if (window.testRunner) {

5 » window.jsTestIsAsync = true;	5 » testRunner.waitUntilDone();

6 testRunner.dumpAsText();	6 testRunner.dumpAsText();

7 }	7 }

8	8

9 function loaded() {	9 function loaded() {

10 // If the garbage collection causes the image load to stop and therefore causes the load event to fire on the main frame, we failed.	10 // If the garbage collection causes the image load to stop and therefore causes the load event to fire on the main frame, we failed.

11 alert("FAIL: The load event fired");	11 alert("FAIL: The load event fired");

12 » finishJSTest();	12 »

	13 » if (window.testRunner)

	14 » » testRunner.notifyDone();

13 }	15 }

14	16

15 </script>	17 </script>

16 <body onload="loaded();">	18 <body onload="loaded();">

17	19

18 This test has an image inside a div. It removes the div, forces garbage collect ion, and makes sure that the window load event does not fire. It also makes sur e there is no crash.<br>	20 This test has an image inside a div. It removes the div, forces garbage collect ion, and makes sure that the window load event does not fire. It also makes sur e there is no crash.<br>

19 <div id="thediv">	21 <div id="thediv">

20 <img src="resources/slowimage.php">	22 <img src="resources/slowimage.php">

21 </div>	23 </div>

22 </body>	24 </body>

23 <script>	25 <script>

24	26

25 function finished() {	27 function finished() {

26 window.stop()	28 window.stop()

27 » finishJSTest();	29 » if (window.testRunner)

	30 » » testRunner.notifyDone();

28 }	31 }

29	32

30 function forceGC() {	33 function forceGC() {

31 gc();	34 gc();

32 setTimeout("finished();", 0);	35 setTimeout("finished();", 0);

33 }	36 }

34	37

35 function removeTheDiv() {	38 function removeTheDiv() {

36 var element = window.document.getElementById("thediv");	39 var element = window.document.getElementById("thediv");

37 element.parentNode.removeChild(element);	40 element.parentNode.removeChild(element);

38 element = null;	41 element = null;

39 setTimeout("forceGC();", 0);	42 setTimeout("forceGC();", 0);

40 }	43 }

41	44

42 setTimeout("removeTheDiv();", 0);	45 setTimeout("removeTheDiv();", 0);

43	46

44 </script>	47 </script>

OLD	NEW