Remove the senderId argument to PushManager.register().

Remove the senderId argument to PushManager.register().

The sender Id can now be provided by developers using the Web Manifest
API. Stop accepting it as part of the API. (The Web Push API has not
shipped yet, so this should not impact developers.)

Specification:
  http://w3c.github.io/push-api/#pushregistrationmanager-interface

BUG=424601
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184414

[Peter Beverloo, 2014-10-17 14:48:14]

peter@chromium.org changed reviewers:
+ mvanouwerkerk@chromium.org

[Peter Beverloo, 2014-10-17 14:48:15]

PTAL. This depends on https://codereview.chromium.org/640593003/.

[Mike West, 2014-10-18 12:04:30]

On 2014/10/17 14:48:15, Peter Beverloo wrote:
> PTAL. This depends on https://codereview.chromium.org/640593003/.

Can you add a link to the spec (which I'm assuming is
http://w3c.github.io/push-api/#pushregistrationmanager-interface)?

LGTM, otherwise.

[Michael van Ouwerkerk, 2014-10-20 17:19:47]

Yay!

lgtm with nit

https://codereview.chromium.org/661093002/diff/1/Source/modules/push_messagin...
File Source/modules/push_messaging/PushManager.h (right):

https://codereview.chromium.org/661093002/diff/1/Source/modules/push_messagin...
Source/modules/push_messaging/PushManager.h:10: #include "wtf/text/WTFString.h"
IWYU

[Peter Beverloo, 2014-10-24 15:50:10]

peter@chromium.org changed reviewers:
+ mkwst@chromium.org

[Peter Beverloo, 2014-10-24 15:50:20]

Both done, thanks!

https://codereview.chromium.org/661093002/diff/1/Source/modules/push_messagin...
File Source/modules/push_messaging/PushManager.h (right):

https://codereview.chromium.org/661093002/diff/1/Source/modules/push_messagin...
Source/modules/push_messaging/PushManager.h:10: #include "wtf/text/WTFString.h"
On 2014/10/20 17:19:47, Michael van Ouwerkerk wrote:
> IWYU

Done.

https://codereview.chromium.org/661093002/diff/1/Source/modules/push_messagin...
File Source/modules/push_messaging/PushManager.idl (right):

https://codereview.chromium.org/661093002/diff/1/Source/modules/push_messagin...
Source/modules/push_messaging/PushManager.idl:4: 
Added a link to the spec per Mike's request.

[Peter Beverloo, 2014-10-26 17:43:50]

The CQ bit was checked by peter@chromium.org

[commit-bot: I haz the power, 2014-10-26 17:44:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/661093002/20001

[commit-bot: I haz the power, 2014-10-26 19:08:36]

Committed patchset #2 (id:20001) as 184414