Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Issue 661083002: Add DumpAccessibilityTree tests (4 of 20) (Closed)

Created:
6 years, 2 months ago by shreeramk
Modified:
6 years, 2 months ago
Reviewers:
dmazzoni, aboxhall
CC:
chromium-reviews, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, jam, yuzo+watch_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git/+/master
Project:
chromium
Visibility:
Public.

Description

Add DumpAccessibilityTree tests (4 of 20) HTML Tag: input type submit, title, textarea ARIA Role: menubar, definition, tree ARIA state/property: aria-checked BUG=170576 Committed: https://crrev.com/a0458670a47098dc18fdcdac2ecdfdbfc552eb66 Cr-Commit-Position: refs/heads/master@{#300910}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : uploading expectations for mac and android #

Total comments: 1

Patch Set 4 : Incorporating comments #

Patch Set 5 : updating expectations for android #

Unified diffs Side-by-side diffs Delta from patch set Stats (+120 lines, -31 lines) Patch
M content/browser/accessibility/dump_accessibility_tree_browsertest.cc View 1 6 chunks +28 lines, -0 lines 0 comments Download
A + content/test/data/accessibility/aria-checked.html View 2 chunks +1 line, -4 lines 0 comments Download
A + content/test/data/accessibility/aria-checked-expected-android.txt View 1 chunk +1 line, -1 line 0 comments Download
A + content/test/data/accessibility/aria-checked-expected-mac.txt View 1 chunk +1 line, -1 line 0 comments Download
A content/test/data/accessibility/aria-checked-expected-win.txt View 1 chunk +5 lines, -0 lines 0 comments Download
A + content/test/data/accessibility/aria-definition.html View 1 1 chunk +2 lines, -4 lines 0 comments Download
A + content/test/data/accessibility/aria-definition-expected-android.txt View 1 chunk +1 line, -0 lines 0 comments Download
A content/test/data/accessibility/aria-definition-expected-mac.txt View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aria-definition-expected-win.txt View 1 chunk +2 lines, -0 lines 0 comments Download
A + content/test/data/accessibility/aria-menubar.html View 2 chunks +1 line, -8 lines 0 comments Download
A content/test/data/accessibility/aria-menubar-expected-android.txt View 1 chunk +6 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aria-menubar-expected-mac.txt View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aria-menubar-expected-win.txt View 1 chunk +6 lines, -0 lines 0 comments Download
A + content/test/data/accessibility/aria-tree.html View 1 1 chunk +2 lines, -4 lines 0 comments Download
A + content/test/data/accessibility/aria-tree-expected-android.txt View 1 1 chunk +2 lines, -1 line 0 comments Download
A content/test/data/accessibility/aria-tree-expected-mac.txt View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aria-tree-expected-win.txt View 1 chunk +2 lines, -0 lines 0 comments Download
M content/test/data/accessibility/input-date.html View 1 chunk +1 line, -0 lines 0 comments Download
A content/test/data/accessibility/input-submit.html View 1 1 chunk +15 lines, -0 lines 0 comments Download
A + content/test/data/accessibility/input-submit-expected-android.txt View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A + content/test/data/accessibility/input-submit-expected-mac.txt View 1 2 1 chunk +4 lines, -3 lines 0 comments Download
A + content/test/data/accessibility/input-submit-expected-win.txt View 1 chunk +1 line, -0 lines 0 comments Download
A content/test/data/accessibility/textarea.html View 1 chunk +14 lines, -0 lines 0 comments Download
A + content/test/data/accessibility/textarea-expected-android.txt View 1 2 1 chunk +5 lines, -4 lines 0 comments Download
A content/test/data/accessibility/textarea-expected-mac.txt View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
A + content/test/data/accessibility/textarea-expected-win.txt View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + content/test/data/accessibility/title.html View 1 chunk +2 lines, -2 lines 0 comments Download
A content/test/data/accessibility/title-expected-android.txt View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A content/test/data/accessibility/title-expected-mac.txt View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
A content/test/data/accessibility/title-expected-win.txt View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (2 generated)
shreeramk
Please review. Thanks :)
6 years, 2 months ago (2014-10-21 11:51:47 UTC) #2
dmazzoni
https://codereview.chromium.org/661083002/diff/40001/content/test/data/accessibility/title.html File content/test/data/accessibility/title.html (right): https://codereview.chromium.org/661083002/diff/40001/content/test/data/accessibility/title.html#newcode4 content/test/data/accessibility/title.html:4: <title>Title of the document</title> Despite what the spec says, ...
6 years, 2 months ago (2014-10-21 15:30:57 UTC) #3
shreeramk
On 2014/10/21 15:30:57, dmazzoni wrote: > https://codereview.chromium.org/661083002/diff/40001/content/test/data/accessibility/title.html > File content/test/data/accessibility/title.html (right): > > https://codereview.chromium.org/661083002/diff/40001/content/test/data/accessibility/title.html#newcode4 > ...
6 years, 2 months ago (2014-10-21 16:36:22 UTC) #4
dmazzoni
On 2014/10/21 16:36:22, shreeramk wrote: > On 2014/10/21 15:30:57, dmazzoni wrote: > > > https://codereview.chromium.org/661083002/diff/40001/content/test/data/accessibility/title.html ...
6 years, 2 months ago (2014-10-21 17:01:45 UTC) #5
shreeramk
Made the proper changes related to title element. Please take a look. Thanks!
6 years, 2 months ago (2014-10-22 05:59:28 UTC) #6
dmazzoni
lgtm
6 years, 2 months ago (2014-10-23 16:26:49 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/661083002/80001
6 years, 2 months ago (2014-10-23 16:27:53 UTC) #9
commit-bot: I haz the power
Committed patchset #5 (id:80001)
6 years, 2 months ago (2014-10-23 17:22:30 UTC) #10
commit-bot: I haz the power
6 years, 2 months ago (2014-10-23 17:23:11 UTC) #11
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/a0458670a47098dc18fdcdac2ecdfdbfc552eb66
Cr-Commit-Position: refs/heads/master@{#300910}

Powered by Google App Engine
This is Rietveld 408576698