Issue 661063002: DevTools: wrong event was used as an indicator of finished write operation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 661063002: DevTools: wrong event was used as an indicator of finished write operation. (Closed)

Created:
6 years, 2 months ago by loislo

Modified:
6 years, 2 months ago

Reviewers:
vsevik, yurys

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

DevTools: wrong event was used as an indicator of finished write operation. FileWriter calls onwrite as notification about the progress of writing. So If we call write again from the onwrite event handler FileWriter fails to do that. Actually we need to use onwriteend callback. BUG=423843 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183886