Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1104)

Issue 661053002: Cleanup: Put more media and profile extensions code behind ENABLE_EXTENSIONS ifdefs. (Closed)

Created:
6 years, 2 months ago by Lei Zhang
Modified:
6 years, 2 months ago
CC:
chromium-reviews, tim+watch_chromium.org, zea+watch_chromium.org, pvalenzuela+watch_chromium.org, posciak+watch_chromium.org, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, wjia+watch_chromium.org, maniscalco+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git/+/master
Project:
chromium
Visibility:
Public.

Description

Cleanup: Put more media and profile extensions code behind ENABLE_EXTENSIONS ifdefs. BUG=424746 Committed: https://crrev.com/2bad4ee392b58240220a56a1a40778faeb67615c Cr-Commit-Position: refs/heads/master@{#300735}

Patch Set 1 #

Total comments: 2

Patch Set 2 : nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -31 lines) Patch
M chrome/browser/media/media_capture_devices_dispatcher.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/media/media_capture_devices_dispatcher.cc View 1 18 chunks +48 lines, -27 lines 0 comments Download
M chrome/browser/profiles/off_the_record_profile_impl.cc View 3 chunks +5 lines, -1 line 0 comments Download
M chrome/browser/sync/profile_sync_components_factory_impl.cc View 7 chunks +9 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (4 generated)
Lei Zhang
6 years, 2 months ago (2014-10-17 18:55:28 UTC) #2
vrk (LEFT CHROMIUM)
Could you add a BUG= link to the CL? https://codereview.chromium.org/661053002/diff/1/chrome/browser/media/media_capture_devices_dispatcher.cc File chrome/browser/media/media_capture_devices_dispatcher.cc (right): https://codereview.chromium.org/661053002/diff/1/chrome/browser/media/media_capture_devices_dispatcher.cc#newcode726 chrome/browser/media/media_capture_devices_dispatcher.cc:726: ...
6 years, 2 months ago (2014-10-17 19:56:44 UTC) #3
Lei Zhang
I filed a bug. https://codereview.chromium.org/661053002/diff/1/chrome/browser/media/media_capture_devices_dispatcher.cc File chrome/browser/media/media_capture_devices_dispatcher.cc (right): https://codereview.chromium.org/661053002/diff/1/chrome/browser/media/media_capture_devices_dispatcher.cc#newcode726 chrome/browser/media/media_capture_devices_dispatcher.cc:726: bool audio_allowed = false; On ...
6 years, 2 months ago (2014-10-17 21:44:51 UTC) #4
vrk (LEFT CHROMIUM)
LGTM d'oh, sorry I forgot about this. Thanks for the cleanup!
6 years, 2 months ago (2014-10-22 14:38:50 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/661053002/20001
6 years, 2 months ago (2014-10-22 14:41:01 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel/builds/3616) linux_chromium_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel/builds/1428)
6 years, 2 months ago (2014-10-22 16:48:27 UTC) #9
Lei Zhang
On 2014/10/22 14:38:50, vrk wrote: > LGTM > > d'oh, sorry I forgot about this. ...
6 years, 2 months ago (2014-10-22 18:49:09 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/661053002/20001
6 years, 2 months ago (2014-10-22 18:50:38 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 2 months ago (2014-10-22 20:15:39 UTC) #13
commit-bot: I haz the power
6 years, 2 months ago (2014-10-22 20:16:43 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2bad4ee392b58240220a56a1a40778faeb67615c
Cr-Commit-Position: refs/heads/master@{#300735}

Powered by Google App Engine
This is Rietveld 408576698