Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 661033005: SkV8Sample: Now with Path2D and Path2DBuilder. (Closed)

Created:
6 years, 1 month ago by jcgregorio
Modified:
6 years, 1 month ago
Reviewers:
robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

SkV8Sample: Now with Path2D and Path2DBuilder. BUG=skia: Committed: https://skia.googlesource.com/skia/+/e001da2558d936fca377e4041ca150ff95c85104

Patch Set 1 #

Patch Set 2 : Fix Path2D memory leak. #

Patch Set 3 : cleaner impl of persistent weak #

Patch Set 4 : cleanup #

Patch Set 5 : more clean #

Patch Set 6 : parseflags #

Total comments: 2

Patch Set 7 : path* #

Unified diffs Side-by-side diffs Delta from patch set Stats (+132 lines, -292 lines) Patch
M experimental/SkV8Example/DrawingMethods.cpp View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M experimental/SkV8Example/Path2D.h View 1 2 3 4 5 6 1 chunk +23 lines, -24 lines 0 comments Download
M experimental/SkV8Example/Path2D.cpp View 1 2 3 4 1 chunk +28 lines, -217 lines 0 comments Download
A + experimental/SkV8Example/Path2DBuilder.h View 3 chunks +10 lines, -9 lines 0 comments Download
A + experimental/SkV8Example/Path2DBuilder.cpp View 1 2 3 17 chunks +46 lines, -29 lines 0 comments Download
M experimental/SkV8Example/SkV8Example.cpp View 1 2 3 4 5 5 chunks +6 lines, -1 line 0 comments Download
M experimental/SkV8Example/js/sample.js View 1 2 3 4 1 chunk +16 lines, -11 lines 0 comments Download
M gyp/v8.gyp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
jcgregorio
6 years, 1 month ago (2014-10-29 12:11:40 UTC) #2
robertphillips
lgtm + suggestion https://codereview.chromium.org/661033005/diff/100001/experimental/SkV8Example/Path2D.h File experimental/SkV8Example/Path2D.h (right): https://codereview.chromium.org/661033005/diff/100001/experimental/SkV8Example/Path2D.h#newcode33 experimental/SkV8Example/Path2D.h:33: May want to return a SkPath* ...
6 years, 1 month ago (2014-10-29 12:20:25 UTC) #3
jcgregorio
https://codereview.chromium.org/661033005/diff/100001/experimental/SkV8Example/Path2D.h File experimental/SkV8Example/Path2D.h (right): https://codereview.chromium.org/661033005/diff/100001/experimental/SkV8Example/Path2D.h#newcode33 experimental/SkV8Example/Path2D.h:33: On 2014/10/29 12:20:24, robertphillips wrote: > May want to ...
6 years, 1 month ago (2014-10-29 12:24:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/661033005/120001
6 years, 1 month ago (2014-10-29 12:25:02 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-10-29 12:33:36 UTC) #7
Message was sent while issue was closed.
Committed patchset #7 (id:120001) as e001da2558d936fca377e4041ca150ff95c85104

Powered by Google App Engine
This is Rietveld 408576698