Mojo: Make sample_test.cc a gtest (and re-enable it).

Mojo: Make sample_test.cc a gtest (and re-enable it).

This also entails making it link with mojo_run_all_unittests, and
changing deps to allow a dependency on testing (hence gtest and
theoretically gmock).

R=darin@chromium.org, davemoore

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=234336

[viettrungluu, 2013-11-11 21:55:16]

darin -- What do you think of allowing tests to depend on testing (i.e.,
gtest/gmock)?

[darin (slow to review), 2013-11-11 21:57:10]

On 2013/11/11 21:55:16, viettrungluu wrote:
> darin -- What do you think of allowing tests to depend on testing (i.e.,
> gtest/gmock)?

Such a dependency seems fine to me.

-Darin

[darin (slow to review), 2013-11-11 21:59:39]

LGTM

https://codereview.chromium.org/66103004/diff/1/mojo/public/bindings/sample/s...
File mojo/public/bindings/sample/sample_test.cc (right):

https://codereview.chromium.org/66103004/diff/1/mojo/public/bindings/sample/s...
mojo/public/bindings/sample/sample_test.cc:189: // TODO(vtl): Remove this? Or
make it optional, so that the test spews less?
This spewage has been useful for developing the bindings. I'm OK with it being
optional. Or, maybe we'll just end up deleting this file in favor of more
focused tests in public/tests/.

[viettrungluu, 2013-11-12 00:05:41]

Committed patchset #2 manually as r234336 (presubmit successful).