Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(492)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 661023002: DevTools: move JS sampling Timeline out of experimental (Closed)

Created:
6 years, 2 months ago by yurys
Modified:
6 years, 2 months ago
Reviewers:
caseq, alph, pfeldman, loislo
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

DevTools: move JS sampling Timeline out of experimental Added "Sampling" option on Timeline. When it is enabled we will stack JavaScript sampling profiler when Timeline is recorded and then will merge JS samples into Timeline events on the flame chart view. BUG=363976 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183864

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -16 lines) Patch
M Source/devtools/front_end/main/Main.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/timeline/TimelineFlameChart.js View 2 chunks +5 lines, -6 lines 0 comments Download
M Source/devtools/front_end/timeline/TimelinePanel.js View 2 chunks +9 lines, -1 line 0 comments Download
M Source/devtools/front_end/timeline/TracingTimelineModel.js View 2 chunks +9 lines, -8 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
yurys
6 years, 2 months ago (2014-10-17 06:39:48 UTC) #2
pfeldman
Does save/load scenario work?
6 years, 2 months ago (2014-10-17 06:43:24 UTC) #3
yurys
On 2014/10/17 06:43:24, pfeldman wrote: > Does save/load scenario work? Yes, it was added in ...
6 years, 2 months ago (2014-10-17 06:58:49 UTC) #4
loislo
lgtm
6 years, 2 months ago (2014-10-17 08:01:46 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/661023002/1
6 years, 2 months ago (2014-10-17 08:02:16 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-10-17 08:40:31 UTC) #8
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as 183864

Powered by Google App Engine
This is Rietveld 408576698