Added switch --disable-app-list-dismiss-on-blur.

Added switch --disable-app-list-dismiss-on-blur.

This switch prevents the app list from being dismissed when it loses
focus (which is helpful when testing the app list or a launcher page).
The other dismissal methods (eg Esc) still work. Honoured on Linux and
Windows only.

BUG=405400
Committed: https://crrev.com/005f390e6af805cb5af100e5ed60a6389a57196e
Cr-Commit-Position: refs/heads/master@{#300235}

[robliao, 2014-10-17 17:34:18]

robliao@chromium.org changed reviewers:
+ robliao@chromium.org

[robliao, 2014-10-17 17:34:18]

https://codereview.chromium.org/661003003/diff/1/chrome/browser/ui/views/app_...
File chrome/browser/ui/views/app_list/win/activation_tracker_win.cc (right):

https://codereview.chromium.org/661003003/diff/1/chrome/browser/ui/views/app_...
chrome/browser/ui/views/app_list/win/activation_tracker_win.cc:69: return;
This needs to return a value.

[robliao, 2014-10-17 17:38:52]

On 2014/10/17 17:34:18, robliao wrote:
>
https://codereview.chromium.org/661003003/diff/1/chrome/browser/ui/views/app_...
> File chrome/browser/ui/views/app_list/win/activation_tracker_win.cc (right):
> 
>
https://codereview.chromium.org/661003003/diff/1/chrome/browser/ui/views/app_...
> chrome/browser/ui/views/app_list/win/activation_tracker_win.cc:69: return;
> This needs to return a value.

For the record, works for me on windows with the return false. Closable with
Alt+F4. Thanks!

[Matt Giuca, 2014-10-19 23:24:25]

mgiuca@chromium.org changed reviewers:
+ tapted@chromium.org

[Matt Giuca, 2014-10-19 23:24:25]

mgiuca@chromium.org changed required reviewers:
+ tapted@chromium.org

[Matt Giuca, 2014-10-19 23:24:26]

https://codereview.chromium.org/661003003/diff/1/chrome/browser/ui/views/app_...
File chrome/browser/ui/views/app_list/win/activation_tracker_win.cc (right):

https://codereview.chromium.org/661003003/diff/1/chrome/browser/ui/views/app_...
chrome/browser/ui/views/app_list/win/activation_tracker_win.cc:69: return;
Thanks. (As I said on the bug, "not mailed out yet because I didn't test on
Windows" --- due to it being late on Friday and still jet lagged). :)

[tapted, 2014-10-19 23:44:20]

So, despite what we just talked about, I actually like this :). So, lgtm. The
technical debt is low and the flag is pretty constrained to the app list
component.

Long-term, we may need better devtools integration. E.g. to catch breakpoints on
first-load. It might make this redundant, but there's a non-trivial amount of
code to do something similar to this CL for browser action popups. I was poking
around at it for mac recently -
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/ui/...

BTW, doing it on mac would be pretty easy too - (just tweak
-(void)windowDidResignMain in app_list_window_controller.mm), but we can worry
about that later (or not at all..)

[Matt Giuca, 2014-10-20 00:22:57]

Oh OK, surprising review. Thanks.

[Matt Giuca, 2014-10-20 00:23:10]

The CQ bit was checked by mgiuca@chromium.org

[commit-bot: I haz the power, 2014-10-20 00:25:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/661003003/20001

[commit-bot: I haz the power, 2014-10-20 09:34:40]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2014-10-20 09:35:52]

Patchset 2 (id:??) landed as
https://crrev.com/005f390e6af805cb5af100e5ed60a6389a57196e
Cr-Commit-Position: refs/heads/master@{#300235}