[linux_views][Win] spoof proof redesign infobar extension with tab.

chrome/browser/ui/views/frame/browser_view.cc

Index: chrome/browser/ui/views/frame/browser_view.cc
diff --git a/chrome/browser/ui/views/frame/browser_view.cc b/chrome/browser/ui/views/frame/browser_view.cc
index 328b449fdf900568cb5364c6700be4889a9ebd7b..211e6863024d52a094a6ac83925b30501621cef4 100644
--- a/chrome/browser/ui/views/frame/browser_view.cc
+++ b/chrome/browser/ui/views/frame/browser_view.cc
@@ -1806,11 +1806,19 @@ void BrowserView::Layout() {
 }
 
 void BrowserView::PaintChildren(gfx::Canvas* canvas) {
-  views::ClientView::PaintChildren(canvas);
+  // Paint the |infobar_container_| last so that it may paint its
+  // overlapping tabs.
+  for (int i = 0, count = child_count(); i < count; ++i) {

[Peter Kasting, 2011/03/04 22:23:42]

Nit: Don't create a separate |count| temp.  child_count() is cheap, call it
directly in the comparison.

[Sheridan Rawlins, 2011/03/05 18:06:54]

FWIW, this was copied from views/view.cc

Done.

+    View* child = GetChildViewAt(i);
+    if (!child) {

[Peter Kasting, 2011/03/04 22:23:42]

Nit: Remove this conditional.

[Sheridan Rawlins, 2011/03/05 18:06:54]

FWIW, this was copied from views/view.cc

Done.

+      NOTREACHED() << "Should not have a NULL child View for index in bounds";
+      continue;
+    }
+    if (child != infobar_container_)
+      child->Paint(canvas);
+  }
 
-  infobar_container_->PaintInfoBarArrows(canvas->AsCanvasSkia(),
-                                         this,
-                                         GetInfoBarArrowCenterX());
+  infobar_container_->Paint(canvas);
 }
 
 void BrowserView::ViewHierarchyChanged(bool is_add,