flimflam: add "psk" security as a way to specify either "wpa" or "rsn"

flimflam: add "psk" security as a way to specify either "wpa" or "rsn"

Add a security type "psk" that means either "wpa-psk" or "rsn-psk".
This can be used when connecting to a service that has unknown
security settings (especially necessary when hidden).

Old-style profile entries are automatically updated.

As part of this work move the code to build network/service group names
into one spot and do it consistently.  This also has the benefit of
getting the table of ssid's that are auto-disambiguated into the core
where it's easier for us to disable this feature.

BUG=chromium-os:9506, chromium-os:7466
TEST=run SecMat (requires updated *Hidden* tests)

Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=8890af9

[Paul Stewart, 2011-03-03 19:55:04]

http://codereview.chromium.org/6609007/diff/2001/src/service.c
File src/service.c (right):

http://codereview.chromium.org/6609007/diff/2001/src/service.c#newcode4526
src/service.c:4526: 
I suggest a test (perhaps not an assert) that
g_str_has_suffix(service->identifier, "_psk").  Glibc doesn't offer you anything
to do direct replacement.

http://codereview.chromium.org/6609007/diff/2001/src/wifi.c
File src/wifi.c (right):

http://codereview.chromium.org/6609007/diff/2001/src/wifi.c#newcode85
src/wifi.c:85: char *connman_wifi_build_group(const char *addr, const char
*name,
Could you comment these specifically so that people understand which routine is
which and how they should be used?

[Sam Leffler, 2011-03-03 21:34:55]

PTAL; re-tested with -a test_pat=*WPA* SecMat

[Paul Stewart, 2011-03-03 23:08:06]

LGTM with nit

http://codereview.chromium.org/6609007/diff/4001/src/wifi.c
File src/wifi.c (right):

http://codereview.chromium.org/6609007/diff/4001/src/wifi.c#newcode107
src/wifi.c:107: * must match the strings constructed above so the associated
services
Need to disambiguate "above" here.