tools/telemetry/telemetry/util/support_binaries.py - Issue 660893002: [Telemetry] Implement automatic installation of optional openCV dependecy.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/util/support_binaries.py

Issue 660893002: [Telemetry] Implement automatic installation of optional openCV dependecy. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: nits Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/telemetry/telemetry/util/support_binaries.py

diff --git a/tools/telemetry/telemetry/util/support_binaries.py b/tools/telemetry/telemetry/util/support_binaries.py

index edccb0f6b3239005cd2f7078935b98ebb5883a70..fcdfc46c387ac8c6a472cd1fe0ccd6ce6e4243f5 100644

--- a/tools/telemetry/telemetry/util/support_binaries.py

+++ b/tools/telemetry/telemetry/util/support_binaries.py

@@ -27,7 +27,7 @@ def FindLocallyBuiltPath(binary_name):

command_mtime = 0

chrome_root = path.GetChromiumSrcDir()

required_mode = os.X_OK

- if binary_name.endswith('.apk'):

+ if binary_name.endswith('.apk') or binary_name.endswith('.so'):

required_mode = os.R_OK

for build_dir, build_type in path.GetBuildDirectories():

candidate = os.path.join(chrome_root, build_dir, build_type, binary_name)

« build/install-build-deps.sh ('K') | « tools/telemetry/telemetry/core/platform/platform_backend.py ('k') | no next file » | no next file with comments »