Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(547)

Issue 660883003: Use scoped_ptr::Pass instead of scoped_ptr::PassAs<T>. (Closed)

Created:
6 years, 2 months ago by dcheng
Modified:
6 years, 2 months ago
Reviewers:
Charlie Reis
CC:
chromium-reviews, darin-cc_chromium.org, feature-media-reviews_chromium.org, jam, jdduke+watch_chromium.org, jochen+watch_chromium.org, mcasas+watch_chromium.org, miu+watch_chromium.org, mkwst+moarreviews-shell_chromium.org, piman+watch_chromium.org, posciak+watch_chromium.org, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Use scoped_ptr::Pass instead of scoped_ptr::PassAs<T>. Cleanup to make future migration to std::move() easier. BUG=423621 Committed: https://crrev.com/103ba304b14008500594318e11785b7f8c45dbf4 Cr-Commit-Position: refs/heads/master@{#300024}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -16 lines) Patch
M content/browser/media/capture/desktop_capture_device_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/child/child_gpu_memory_buffer_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/child/child_thread.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/child/web_gesture_curve_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/common/gpu/media/v4l2_video_device.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/common/input/input_param_traits.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/input/input_param_traits_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M content/public/test/browser_test_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/browser/shell_url_request_context_getter.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/test/layouttest_support.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/test/test_render_frame_host_factory.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
dcheng
6 years, 2 months ago (2014-10-16 22:01:26 UTC) #2
Charlie Reis
LGTM
6 years, 2 months ago (2014-10-16 23:37:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/660883003/1
6 years, 2 months ago (2014-10-16 23:44:05 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-17 00:24:44 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-17 00:25:25 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/103ba304b14008500594318e11785b7f8c45dbf4
Cr-Commit-Position: refs/heads/master@{#300024}

Powered by Google App Engine
This is Rietveld 408576698