Issue 660883002: "Fix" debugger's setMatrix handling

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 660883002: "Fix" debugger's setMatrix handling (Closed)

Created:
6 years, 2 months ago by robertphillips

Modified:
6 years, 2 months ago

Reviewers:
mtklein

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

More Reviews

Description

"Fix" debugger's setMatrix handling This remedies two problems with the debugger's matrix handling: 1) the user matrix was not being passed to the setMatrix command (for a concat) 2) the setting of the user matrix was not consistently forcing a complete re-rendering of the scene BUG=skia:3018 Committed: https://skia.googlesource.com/skia/+/70171683e6977af7472f0f465bd81852d0644ddd

Patch Set 1 #

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+20 lines, -3 lines)			Patch
M	src/utils/debugger/SkDebugCanvas.h	View	2 chunks	+2 lines, -0 lines	0 comments	Download
M	src/utils/debugger/SkDebugCanvas.cpp	View	5 chunks	+6 lines, -2 lines	0 comments	Download
M	src/utils/debugger/SkDrawCommand.h	View	2 chunks	+5 lines, -0 lines	0 comments	Download
M	src/utils/debugger/SkDrawCommand.cpp	View	1 chunk	+7 lines, -1 line	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/660883002/1

6 years, 2 months ago (2014-10-16 21:21:49 UTC) #5

commit-bot: I haz the power

6 years, 2 months ago (2014-10-16 21:28:49 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as 70171683e6977af7472f0f465bd81852d0644ddd

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages