Remove isSyncDatabase in WebDatabaseObserver [1/3]

Source/modules/webdatabase/Database.cpp

 /*
  * Copyright (C) 2013 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 700 matching lines @@
 
 // These are used to generate histograms of errors seen with websql.
 // See about:histograms in chromium.
 void Database::reportOpenDatabaseResult(int errorSite, int webSqlErrorCode, int sqliteErrorCode)
 {
     if (Platform::current()->databaseObserver()) {
         Platform::current()->databaseObserver()->reportOpenDatabaseResult(
             createDatabaseIdentifierFromSecurityOrigin(securityOrigin()),
             stringIdentifier(), false,
             errorSite, webSqlErrorCode, sqliteErrorCode);
+        Platform::current()->databaseObserver()->reportOpenDatabaseResult(
+            createDatabaseIdentifierFromSecurityOrigin(securityOrigin()),
+            stringIdentifier(), errorSite, webSqlErrorCode, sqliteErrorCode);

[kinuko, 2014/10/27 06:31:40]

I don't think we should do this.

     }
 }
 
 void Database::reportChangeVersionResult(int errorSite, int webSqlErrorCode, int sqliteErrorCode)
 {
     if (Platform::current()->databaseObserver()) {
         Platform::current()->databaseObserver()->reportChangeVersionResult(
             createDatabaseIdentifierFromSecurityOrigin(securityOrigin()),
             stringIdentifier(), false,
             errorSite, webSqlErrorCode, sqliteErrorCode);
+        Platform::current()->databaseObserver()->reportChangeVersionResult(
+            createDatabaseIdentifierFromSecurityOrigin(securityOrigin()),
+            stringIdentifier(), errorSite, webSqlErrorCode, sqliteErrorCode);
     }
 }
 
 void Database::reportStartTransactionResult(int errorSite, int webSqlErrorCode, int sqliteErrorCode)
 {
     if (Platform::current()->databaseObserver()) {
         Platform::current()->databaseObserver()->reportStartTransactionResult(
             createDatabaseIdentifierFromSecurityOrigin(securityOrigin()),
             stringIdentifier(), false,
             errorSite, webSqlErrorCode, sqliteErrorCode);
+        Platform::current()->databaseObserver()->reportStartTransactionResult(
+            createDatabaseIdentifierFromSecurityOrigin(securityOrigin()),
+            stringIdentifier(), errorSite, webSqlErrorCode, sqliteErrorCode);
     }
 }
 
 void Database::reportCommitTransactionResult(int errorSite, int webSqlErrorCode, int sqliteErrorCode)
 {
     if (Platform::current()->databaseObserver()) {
         Platform::current()->databaseObserver()->reportCommitTransactionResult(
             createDatabaseIdentifierFromSecurityOrigin(securityOrigin()),
             stringIdentifier(), false,
             errorSite, webSqlErrorCode, sqliteErrorCode);
+        Platform::current()->databaseObserver()->reportCommitTransactionResult(
+            createDatabaseIdentifierFromSecurityOrigin(securityOrigin()),
+            stringIdentifier(), errorSite, webSqlErrorCode, sqliteErrorCode);
     }
 }
 
 void Database::reportExecuteStatementResult(int errorSite, int webSqlErrorCode, int sqliteErrorCode)
 {
     if (Platform::current()->databaseObserver()) {
         Platform::current()->databaseObserver()->reportExecuteStatementResult(
             createDatabaseIdentifierFromSecurityOrigin(securityOrigin()),
             stringIdentifier(), false,
             errorSite, webSqlErrorCode, sqliteErrorCode);
+        Platform::current()->databaseObserver()->reportExecuteStatementResult(
+            createDatabaseIdentifierFromSecurityOrigin(securityOrigin()),
+            stringIdentifier(), errorSite, webSqlErrorCode, sqliteErrorCode);
     }
 }
 
 void Database::reportVacuumDatabaseResult(int sqliteErrorCode)
 {
     if (Platform::current()->databaseObserver()) {
         Platform::current()->databaseObserver()->reportVacuumDatabaseResult(
             createDatabaseIdentifierFromSecurityOrigin(securityOrigin()),
             stringIdentifier(), false, sqliteErrorCode);
+        Platform::current()->databaseObserver()->reportVacuumDatabaseResult(
+            createDatabaseIdentifierFromSecurityOrigin(securityOrigin()),
+            stringIdentifier(), sqliteErrorCode);
     }
 }
 
 void Database::logErrorMessage(const String& message)
 {
     executionContext()->addConsoleMessage(ConsoleMessage::create(StorageMessageSource, ErrorMessageLevel, message));
 }
 
 ExecutionContext* Database::executionContext() const
 {
@@ skipping 144 matching lines @@
 SecurityOrigin* Database::securityOrigin() const
 {
     if (executionContext()->isContextThread())
         return m_contextThreadSecurityOrigin.get();
     if (databaseContext()->databaseThread()->isDatabaseThread())
         return m_databaseThreadSecurityOrigin.get();
     return 0;
 }
 
 } // namespace blink