Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Unified Diff: public/web/WebFrame.h

Issue 660863002: [DevTools] Added public method for async execution of scripts (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: platform/WebExecuteScriptCallback -> web/WebScriptCallback Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: public/web/WebFrame.h
diff --git a/public/web/WebFrame.h b/public/web/WebFrame.h
index 0250a19423b095f1649b85f50ec182784bb24d27..5ba22ff4510b5aaeec57c15d292671642114c76d 100644
--- a/public/web/WebFrame.h
+++ b/public/web/WebFrame.h
@@ -63,6 +63,7 @@ class WebData;
class WebDataSource;
class WebDocument;
class WebElement;
+class WebScriptCallback;
class WebFormElement;
class WebFrameClient;
class WebInputElement;
@@ -301,12 +302,17 @@ public:
// that the script evaluated to.
virtual v8::Handle<v8::Value> executeScriptAndReturnValue(
const WebScriptSource&) = 0;
+ virtual void executeScriptAndReturnValue(
+ const WebScriptSource&, WebScriptCallback*) = 0;
dcheng 2014/10/20 07:13:54 Please address my comments from the first patchset
// worldID must be > 0 (as 0 represents the main world).
// worldID must be < EmbedderWorldIdLimit, high number used internally.
virtual void executeScriptInIsolatedWorld(
int worldID, const WebScriptSource* sourcesIn, unsigned numSources,
int extensionGroup, WebVector<v8::Local<v8::Value> >* results) = 0;
+ virtual void executeScriptInIsolatedWorld(
+ int worldID, const WebScriptSource* sourcesIn, unsigned numSources,
+ int extensionGroup, WebScriptCallback*) = 0;
// Call the function with the given receiver and arguments, bypassing
// canExecute().

Powered by Google App Engine
This is Rietveld 408576698