Source/bindings/core/v8/custom/V8WindowCustom.cpp - Issue 660863002: [DevTools] Added public method for async execution of scripts

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/core/v8/custom/V8WindowCustom.cpp

Issue 660863002: [DevTools] Added public method for async execution of scripts (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: platform/WebExecuteScriptCallback -> web/WebScriptCallback Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/bindings/core/v8/ScheduledActionWithCallback.cpp ('K') | « Source/bindings/core/v8/ScheduledActionWithCallback.cpp ('k') | Source/bindings/core/v8/custom/V8WorkerGlobalScopeCustom.cpp » ('j') | Source/core/dom/ExecutionContext.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/core/v8/custom/V8WindowCustom.cpp

diff --git a/Source/bindings/core/v8/custom/V8WindowCustom.cpp b/Source/bindings/core/v8/custom/V8WindowCustom.cpp

index 6a829319c9479f6cd212bbe010d3de0614ec940b..aa7e32520362598f05398bdbe5aee52fe4428199 100644

--- a/Source/bindings/core/v8/custom/V8WindowCustom.cpp

+++ b/Source/bindings/core/v8/custom/V8WindowCustom.cpp

@@ -107,7 +107,7 @@ static void windowSetTimeoutImpl(const v8::FunctionCallbackInfo<v8::Value>& info

if (!BindingSecurity::shouldAllowAccessToFrame(info.GetIsolate(), impl->frame(), exceptionState))

return;

- OwnPtr<ScheduledAction> action;

+ OwnPtr<ScheduledActionBase> action;

if (function->IsFunction()) {

int paramCount = argumentCount >= 2 ? argumentCount - 2 : 0;

OwnPtr<v8::Local<v8::Value>[]> params;