Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 660853003: When rendering df fonts, pass drawText() down to drawPosText(). (Closed)

Created:
6 years, 2 months ago by jvanverth1
Modified:
6 years, 2 months ago
Reviewers:
bungeman-skia, egdaniel
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

When rendering df fonts, pass drawText() down to drawPosText(). First pass at getting color emoji working for distance fields. BUG=skia:3033 Committed: https://skia.googlesource.com/skia/+/2b9dc1d0fff7e1e206721b872a9ba989f5829271

Patch Set 1 #

Patch Set 2 : Fix typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -60 lines) Patch
M src/gpu/GrDistanceFieldTextContext.cpp View 1 4 chunks +52 lines, -60 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
jvanverth1
This method doesn't seem to work for hinted text, but I need it to fix ...
6 years, 2 months ago (2014-10-16 19:03:52 UTC) #2
jvanverth1
On 2014/10/16 19:03:52, jvanverth1 wrote: > This method doesn't seem to work for hinted text, ...
6 years, 2 months ago (2014-10-20 12:59:03 UTC) #3
egdaniel
lgtm
6 years, 2 months ago (2014-10-20 13:17:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/660853003/1
6 years, 2 months ago (2014-10-20 13:18:08 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: Build-Ubuntu13.10-GCC4.8-Arm7-Debug-Android-Trybot on client.skia.compile (http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu13.10-GCC4.8-Arm7-Debug-Android-Trybot/builds/102) Build-Ubuntu13.10-GCC4.8-x86_64-Release-Trybot on client.skia.compile (http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu13.10-GCC4.8-x86_64-Release-Trybot/builds/113)
6 years, 2 months ago (2014-10-20 13:19:49 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/660853003/20001
6 years, 2 months ago (2014-10-20 13:42:33 UTC) #10
commit-bot: I haz the power
6 years, 2 months ago (2014-10-20 13:49:03 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 2b9dc1d0fff7e1e206721b872a9ba989f5829271

Powered by Google App Engine
This is Rietveld 408576698