Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2012)

Unified Diff: chrome/browser/metrics/jumplist_metrics_win.h

Issue 660813002: [Win] Add a fast profile switcher to the Windows taskbar item. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase + added renamed jumplist files Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/metrics/jumplist_metrics_win.h
diff --git a/chrome/browser/metrics/jumplist_metrics_win.h b/chrome/browser/metrics/jumplist_metrics_win.h
new file mode 100644
index 0000000000000000000000000000000000000000..da744b108778d82271db5008961d175069c2ab68
--- /dev/null
+++ b/chrome/browser/metrics/jumplist_metrics_win.h
@@ -0,0 +1,30 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_METRICS_JUMPLIST_METRICS_WIN_H_
+#define CHROME_BROWSER_METRICS_JUMPLIST_METRICS_WIN_H_
+
+#include <string>
+
+namespace jumplist {
+
+// Enum for counting which category was clicked.
jwd 2014/11/12 21:55:41 Add a comment that these are used with a histogram
noms (inactive) 2014/11/13 16:59:55 Done.
+enum JumplistCategory {
+ RECENTLY_CLOSED_URL = 0, // A URL from the "Recently Closed" category.
+ MOST_VISITED_URL, // A URL from the "Most Visited" category.
+ SWITCH_TO_PROFILE, // A profile name from the "People" category.
+ CATEGORY_UNKNOWN, // An invalid category.
+ NUM_JUMPLIST_CATEGORY_METRICS
+};
+
+// Category types that can be logged with the --win-jumplist-action switch.
+extern const char kMostVisitedCategory[];
+extern const char kProfilesCategory[];
+extern const char kRecentlyClosedCategory[];
+
+void LogJumplistActionFromSwitchValue(const std::string& value);
jwd 2014/11/12 21:55:41 Add a comment please, mention histograms.
noms (inactive) 2014/11/13 16:59:55 Done.
+
+} // namespace jumplist
+
+#endif // CHROME_BROWSER_METRICS_JUMPLIST_METRICS_WIN_H_

Powered by Google App Engine
This is Rietveld 408576698