[Win] Add a fast profile switcher to the Windows taskbar item.

chrome/browser/jumplist_win.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_JUMPLIST_WIN_H_
 #define CHROME_BROWSER_JUMPLIST_WIN_H_
 
 #include <list>
 #include <string>
 #include <utility>
 #include <vector>
 
 #include "base/files/file_path.h"
 #include "base/memory/weak_ptr.h"
 #include "base/synchronization/lock.h"
 #include "base/task/cancelable_task_tracker.h"
 #include "chrome/browser/history/history_service.h"
 #include "chrome/browser/jumplist_updater_win.h"
 #include "chrome/browser/prefs/incognito_mode_prefs.h"
+#include "chrome/browser/profiles/avatar_menu.h"
+#include "chrome/browser/profiles/avatar_menu_observer.h"
 #include "chrome/browser/sessions/tab_restore_service.h"
 #include "chrome/browser/sessions/tab_restore_service_observer.h"
 #include "components/history/core/browser/history_types.h"
 #include "content/public/browser/browser_thread.h"
 
 namespace chrome {
 struct FaviconImageResult;
 }
 
 namespace content {
@@ skipping 16 matching lines @@
 // the JumpList whenever a change is detected.
 //
 // Updating a JumpList requires some file operations and it is not good to
 // update it in a UI thread. To solve this problem, this class posts to a
 // runnable method when it actually updates a JumpList.
 //
 // Note. base::CancelableTaskTracker is not thread safe, so we
 // always delete JumpList on UI thread (the same thread it got constructed on).
 class JumpList : public TabRestoreServiceObserver,
                  public content::NotificationObserver,
+                 public AvatarMenuObserver,
                  public base::RefCountedThreadSafe<
                      JumpList, content::BrowserThread::DeleteOnUIThread> {
  public:
   explicit JumpList(Profile* profile);
 
   // NotificationObserver implementation.
   virtual void Observe(int type,
                        const content::NotificationSource& source,
                        const content::NotificationDetails& details);
 
   // Observer callback for TabRestoreService::Observer to notify when a tab is
   // added or removed.
   virtual void TabRestoreServiceChanged(TabRestoreService* service);
 
   // Observer callback to notice when our associated TabRestoreService
   // is destroyed.
   virtual void TabRestoreServiceDestroyed(TabRestoreService* service);
 
+  // Overridden from AvatarMenuObserver:
+  virtual void OnAvatarMenuChanged(AvatarMenu* avatar_menu) override;

[tapted, 2014/11/03 23:57:06]

nit: I think this will eventually lose the `virtual`, so I'd leave that off in
case the cleanup CL wins the race.. The overrides above are also missing any
`override` since msvc doesn't check, but a cleanup CL should get those.

[noms (inactive), 2014/11/04 20:03:09]

Done. Cleaned up the other ones too.

+
   // Cancel a pending jumplist update.
   void CancelPendingUpdate();
 
   // Terminate the jumplist: cancel any pending updates and stop observing
   // the Profile and its services. This must be called before the |profile_|
   // is destroyed.
   void Terminate();
 
   // Returns true if the custom JumpList is enabled.
   // The custom jumplist works only on Windows 7 and above.
@@ skipping 43 matching lines @@
   void PostRunUpdate();
 
   // Runnable method that updates the jumplist, once all the data
   // has been fetched.
   void RunUpdate(IncognitoModePrefs::Availability incognito_availability);
 
   // Helper method for RunUpdate to create icon files for the asynchrounously
   // loaded icons.
   void CreateIconFiles(const ShellLinkItemList& item_list);
 
+  // Update the cached list of profile avatars to be used as the Profiles
+  // category JumpList icons.
+  void UpdateProfileAvatars();
+
   // Tracks FaviconService tasks.
   base::CancelableTaskTracker cancelable_task_tracker_;
 
   // The Profile object is used to listen for events
   Profile* profile_;
 
   // Lives on the UI thread.
   scoped_ptr<content::NotificationRegistrar> registrar_;
   scoped_ptr<PrefChangeRegistrar> pref_change_registrar_;
 
@@ skipping 20 matching lines @@
   // comes in before it finishes.
   base::CancelableTaskTracker::TaskId task_id_;
 
   // Lock for most_visited_pages_, recently_closed_pages_, icon_urls_
   // as they may be used by up to 3 threads.
   base::Lock list_lock_;
 
   // For callbacks may be run after destruction.
   base::WeakPtrFactory<JumpList> weak_ptr_factory_;
 
+  scoped_ptr<AvatarMenu> avatar_menu_;

[tapted, 2014/11/03 23:57:06]

nit: comment? (for consistency - it looks lonely)

[noms (inactive), 2014/11/04 20:03:09]

Done.

+
+  // Profile avatars used as icons by the items in the Profiles category.
+  std::vector<gfx::Image> profile_avatars_;
+
   DISALLOW_COPY_AND_ASSIGN(JumpList);
 };
 
 #endif  // CHROME_BROWSER_JUMPLIST_WIN_H_