[Win] Add a fast profile switcher to the Windows taskbar item.

chrome/browser/jumplist_metrics.h

+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_JUMPLIST_METRICS_H_

[tapted, 2014/11/10 23:47:41]

this might be better in a subfolder of chrome/browser, but I'm not sure what
that would be. I see why you didn't immediately go for c/b/profiles, but I'm
leaning towards that as marginally better anyway. 

Other options could be c/b/metrics or c/b/ui/startup or a new folder
(c/b/shell_ingegration?), I think I like c/b/profiles the best, but an OWNER
might have a better idea.

[noms (inactive), 2014/11/12 19:04:11]

I'm an owner of profiles :)
The reason why I didn't put it in profiles is that it isn't really profile
related. I've added logging that is useful even if the Finch experiment doesn't
pan out. I think I like c/b/metrics the best, so I did that.

+#define CHROME_BROWSER_JUMPLIST_METRICS_H_
+
+#include <string>
+
+class JumplistMetrics {

[tapted, 2014/11/10 23:47:41]

nit: needs a comment, or (probably better) drop the class, since it's just
bundling statics which the style guide doesn't like. (although a class is
consistent with c/b/profiles/profile_metrics.h, but not with others like
c/b/diagnostics/diagnostics_metrics.h)

[noms (inactive), 2014/11/12 19:04:11]

Done. I've added a namespace. I hope that's not worse :/

+ public:
+  // Enum for counting which category was clicked.
+  enum JumplistCategory {
+    RECENTLY_CLOSED_URL = 0,  // A URL from the "Recently Closed" category.
+    MOST_VISITED_URL,         // A URL from the "Most Visited" category.
+    SWITCH_TO_PROFILE,        // A profile name from the "People" category.
+    CATEGORY_UNKNOWN,         // An invalid category.
+    NUM_JUMPLIST_CATEGORY_METRICS
+  };
+
+  // Category types that can be logged with the --win-jumplist-action switch.
+  static const char kMostVisitedCategory[];
+  static const char kProfilesCategory[];
+  static const char kRecentlyClosedCategory[];
+
+  static void LogJumplistActionFromSwitchValue(const std::string& value);
+};
+
+#endif  // CHROME_BROWSER_JUMPLIST_METRICS_H_