[Win] Add a fast profile switcher to the Windows taskbar item.

chrome/browser/chrome_browser_main.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chrome_browser_main.h"
 
 #include <set>
 #include <string>
 #include <vector>
 
@@ skipping 147 matching lines @@
 
 #if defined(OS_WIN)
 #include "base/environment.h"  // For PreRead experiment.
 #include "base/win/windows_version.h"
 #include "chrome/browser/browser_util_win.h"
 #include "chrome/browser/chrome_browser_main_win.h"
 #include "chrome/browser/chrome_select_file_dialog_factory_win.h"
 #include "chrome/browser/component_updater/sw_reporter_installer_win.h"
 #include "chrome/browser/first_run/try_chrome_dialog_view.h"
 #include "chrome/browser/first_run/upgrade_util_win.h"
+#include "chrome/browser/jumplist_metrics.h"
 #include "chrome/browser/ui/network_profile_bubble.h"
 #include "chrome/installer/util/helper.h"
 #include "chrome/installer/util/install_util.h"
 #include "chrome/installer/util/shell_util.h"
 #include "net/base/net_util.h"
 #include "ui/base/l10n/l10n_util_win.h"
 #include "ui/gfx/win/dpi.h"
 #include "ui/shell_dialogs/select_file_dialog.h"
 #endif  // defined(OS_WIN)
 
@@ skipping 270 matching lines @@
 }
 
 #if !defined(OS_ANDROID)
 bool ProcessSingletonNotificationCallback(
     const CommandLine& command_line,
     const base::FilePath& current_directory) {
   // Drop the request if the browser process is already in shutdown path.
   if (!g_browser_process || g_browser_process->IsShuttingDown())
     return false;
 
+#if defined(OS_WIN)
+  // Log whether this process was a result of an action in the Windows Jumplist.
+  if (command_line.HasSwitch(switches::kWinJumplistAction)) {
+    JumplistMetrics::LogJumplistActionFromSwitchValue(
+        command_line.GetSwitchValueASCII(switches::kWinJumplistAction));

[tapted, 2014/11/10 23:47:41]

If you want to catch metrics recording for the cases Chrome isn't running, I
think this will need to go somewhere else. I'm thinking mainly about the
pinned-to-start-menu case (as opposed to pinned-to-taskbar). i.e. like
https://drive.google.com/a/google.com/file/d/0Bw8WCbRaSxWbYTlaTVRfNXRWM00/vie...
[corp]

You probably want this in StartupBrowserCreator::ProcessCmdLineImpl(). Maybe the
not-running case is different enough to want to have a separate UMA (or
different enum values). Otherwise (if you stay with just one UMA axis), you'll
also want to move the activate-existing-browser part back into
ProcessCmdLineImpl (from ProcessCommandLineAlreadyRunning), otherwise the logic
will bail out before recording UMA.

edit: after seeing sky's comment - perhaps moving it back into
ProcessCmdLineImpl is better anyway :)

[noms (inactive), 2014/11/12 19:04:11]

Ahh, I misunderstood when this was called. I was under the impression it was
called every time you open a new browser, but I don't think that's true. Done!

+  }
+#endif
+
   if (command_line.HasSwitch(switches::kOriginalProcessStartTime)) {
     std::string start_time_string =
         command_line.GetSwitchValueASCII(switches::kOriginalProcessStartTime);
     int64 remote_start_time;
     if (base::StringToInt64(start_time_string, &remote_start_time)) {
       base::TimeDelta elapsed =
           base::Time::Now() - base::Time::FromInternalValue(remote_start_time);
       if (command_line.HasSwitch(switches::kFastStart)) {
         UMA_HISTOGRAM_LONG_TIMES(
             "Startup.WarmStartTimeFromRemoteProcessStartFast", elapsed);
@@ skipping 1230 matching lines @@
   chromeos::CrosSettings::Shutdown();
 #endif
 #endif
 }
 
 // Public members:
 
 void ChromeBrowserMainParts::AddParts(ChromeBrowserMainExtraParts* parts) {
   chrome_extra_parts_.push_back(parts);
 }