Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Issue 660803003: The User Manager's Chrome logo should flip nicely in RTL. (Closed)

Created:
6 years, 2 months ago by noms (inactive)
Modified:
6 years, 2 months ago
Reviewers:
xiyuan
CC:
chromium-reviews, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

The User Manager's Chrome logo should flip nicely in RTL. At the moment it stays on the right hand side, unflipped, overlapping the other flipped buttons. >_< BUG=NONE Committed: https://crrev.com/b613325a68e702ec8df3d1f2ac1f2d84a4d4f2c0 Cr-Commit-Position: refs/heads/master@{#299972}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/browser/resources/user_manager/control_bar.css View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
noms (inactive)
6 years, 2 months ago (2014-10-16 18:26:55 UTC) #2
xiyuan
lgtm
6 years, 2 months ago (2014-10-16 18:59:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/660803003/1
6 years, 2 months ago (2014-10-16 19:03:50 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-16 20:45:13 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-16 20:46:11 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b613325a68e702ec8df3d1f2ac1f2d84a4d4f2c0
Cr-Commit-Position: refs/heads/master@{#299972}

Powered by Google App Engine
This is Rietveld 408576698