Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 660793002: [New Multicolumn] Let updatePagination() do its job also when composited. (Closed)

Created:
6 years, 2 months ago by mstensho (USE GERRIT)
Modified:
6 years, 2 months ago
CC:
blink-layers+watch_chromium.org, blink-reviews, blink-reviews-rendering, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, rune+blink, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

[New Multicolumn] Let updatePagination() do its job also when composited. Otherwise, layers inside multicol will become non-paginated if relaid out after initial paint. BUG=359877 R=jchaffraix@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184012

Patch Set 1 #

Total comments: 2

Patch Set 2 : code review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -7 lines) Patch
M LayoutTests/TestExpectations View 1 chunk +1 line, -0 lines 0 comments Download
A LayoutTests/fast/multicol/composited-relpos-resize.html View 1 chunk +20 lines, -0 lines 0 comments Download
A LayoutTests/fast/multicol/composited-relpos-resize-expected.html View 1 chunk +21 lines, -0 lines 0 comments Download
M Source/core/rendering/RenderLayer.cpp View 1 3 chunks +6 lines, -7 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
mstensho (USE GERRIT)
6 years, 2 months ago (2014-10-16 12:39:39 UTC) #1
Julien - ping for review
lgtm https://codereview.chromium.org/660793002/diff/1/Source/core/rendering/RenderLayer.cpp File Source/core/rendering/RenderLayer.cpp (right): https://codereview.chromium.org/660793002/diff/1/Source/core/rendering/RenderLayer.cpp#newcode476 Source/core/rendering/RenderLayer.cpp:476: bool regionBasedColumnsUsed = useRegionBasedColumns(); Style: boolean should have ...
6 years, 2 months ago (2014-10-20 15:52:37 UTC) #2
mstensho (USE GERRIT)
https://codereview.chromium.org/660793002/diff/1/Source/core/rendering/RenderLayer.cpp File Source/core/rendering/RenderLayer.cpp (right): https://codereview.chromium.org/660793002/diff/1/Source/core/rendering/RenderLayer.cpp#newcode476 Source/core/rendering/RenderLayer.cpp:476: bool regionBasedColumnsUsed = useRegionBasedColumns(); On 2014/10/20 15:52:36, Julien Chaffraix ...
6 years, 2 months ago (2014-10-20 18:54:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/660793002/20001
6 years, 2 months ago (2014-10-20 18:55:07 UTC) #5
commit-bot: I haz the power
6 years, 2 months ago (2014-10-20 20:30:06 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 184012

Powered by Google App Engine
This is Rietveld 408576698