Don't require Mac 10.6 SDK for official iOS builds.

Don't require Mac 10.6 SDK for official iOS builds.

iOS does not have this requirement, but we've been installing the 10.6
SDK on the buildbot slaves to make the 'find_sdk.py --verify' call
happy. However, iossim no longer builds with 10.6 so it's time to update
the mac_sdk_min for iOS to 10.8 and remove the false requirement for
official builds.

BUG=418602
Committed: https://crrev.com/3a721cdeaa08279e20010c88e282b4a12bcc3ee5
Cr-Commit-Position: refs/heads/master@{#299904}

[lliabraa, 2014-10-16 13:19:38]

lliabraa@chromium.org changed reviewers:
+ rohitrao@chromium.org, rsesek@chromium.org

[lliabraa, 2014-10-16 13:19:38]

@rohitrao for iOS
@rsesek for mac? (feel free to recommend a different reviewer; thakis is OOO
until 10/27)

https://codereview.chromium.org/660783004/diff/1/build/common.gypi
File build/common.gypi (left):

https://codereview.chromium.org/660783004/diff/1/build/common.gypi#oldcode1599
build/common.gypi:1599: 'mac_sdk%': '<!(python <(DEPTH)/build/mac/find_sdk.py
10.6)',
AFAICT, this is redundant as we're also setting this value in the OS = ios or
mac condition below.

[lliabraa, 2014-10-16 14:50:32]

lliabraa@chromium.org changed reviewers:
+ stuartmorgan@chromium.org

[lliabraa, 2014-10-16 14:54:04]

lliabraa@chromium.org changed reviewers:
+ mark@chromium.org
- rsesek@chromium.org

[lliabraa, 2014-10-16 14:54:04]

-rsesek, +mark

[stuartmorgan, 2014-10-16 14:59:06]

lgtm

[Mark Mentovai, 2014-10-16 15:38:40]

LGTM

[lliabraa, 2014-10-16 15:40:02]

The CQ bit was checked by lliabraa@chromium.org

[commit-bot: I haz the power, 2014-10-16 15:40:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/660783004/20001

[commit-bot: I haz the power, 2014-10-16 16:47:05]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2014-10-16 16:47:40]

Patchset 2 (id:??) landed as
https://crrev.com/3a721cdeaa08279e20010c88e282b4a12bcc3ee5
Cr-Commit-Position: refs/heads/master@{#299904}

[xhwang, 2014-10-16 16:55:23]

xhwang@chromium.org changed reviewers:
+ xhwang@chromium.org

[xhwang, 2014-10-16 16:55:24]

https://codereview.chromium.org/660783004/diff/20001/build/common.gypi
File build/common.gypi (right):

https://codereview.chromium.org/660783004/diff/20001/build/common.gypi#newcod...
build/common.gypi:1868: ['branding=="Chrome" and buildtype=="Official" and
OS==mac', {
This should be OS=="mac".

It's causing failures, e.g: 
http://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Mac/bu...

[lliabraa, 2014-10-16 17:46:15]

On 2014/10/16 16:55:24, xhwang wrote:
> https://codereview.chromium.org/660783004/diff/20001/build/common.gypi
> File build/common.gypi (right):
> 
>
https://codereview.chromium.org/660783004/diff/20001/build/common.gypi#newcod...
> build/common.gypi:1868: ['branding=="Chrome" and buildtype=="Official" and
> OS==mac', {
> This should be OS=="mac".
> 
> It's causing failures, e.g: 
>
http://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Mac/bu...

Closing the loop: this has been fixed with
https://chromiumcodereview.appspot.com/663553002/

I'm also following up with chrome-infra since Google Chrome Mac is not run as
part of CQ (or even available in the list of try jobs on reitveld)

Sorry!