Source/core/html/HTMLFormControlElement.h - Issue 660783002: Implement reportValidity()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLFormControlElement.h

Issue 660783002: Implement reportValidity() (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Apply keishi's comments + pull Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/fast/forms/reportValidity-select-form.html ('K') | « Source/core/html/HTMLFieldSetElement.idl ('k') | Source/core/html/HTMLFormControlElement.cpp » ('j') | Source/core/html/HTMLFormControlElement.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/html/HTMLFormControlElement.h

diff --git a/Source/core/html/HTMLFormControlElement.h b/Source/core/html/HTMLFormControlElement.h

index f56ab7ee0d8a84523b2a5a02aeb2bc81b736e474..c753d9c656d3df48ecaa24e99c52b9be75c616fe 100644

--- a/Source/core/html/HTMLFormControlElement.h

+++ b/Source/core/html/HTMLFormControlElement.h

@@ -90,7 +90,9 @@ public:

void updateVisibleValidationMessage();

void hideVisibleValidationMessage();

- bool checkValidity(WillBeHeapVector<RefPtrWillBeMember<FormAssociatedElement> >* unhandledInvalidControls = 0, CheckValidityEventBehavior = CheckValidityDispatchInvalidEvent);

+ bool checkValidity(WillBeHeapVector<RefPtrWillBeMember<HTMLFormControlElement> >* unhandledInvalidControls = 0, CheckValidityEventBehavior = CheckValidityDispatchInvalidEvent);

+ bool reportValidity();

+ bool showValidationMessage();

// This must be called when a validation constraint or control value is changed.

void setNeedsValidityCheck();

virtual void setCustomValidity(const String&) override final;