Put some references to __DATE__ and __TIME__ behind a preprocessor flag.

base/build_time.cc

Index: base/build_time.cc
diff --git a/base/build_time.cc b/base/build_time.cc
index 760269a3ffe33aada613e23476815466f1420c69..49b5a20f2adce71100b0726d9de5e20aafcb37b3 100644
--- a/base/build_time.cc
+++ b/base/build_time.cc
@@ -16,7 +16,11 @@ Time GetBuildTime() {
   //
   // __DATE__ is exactly "Mmm DD YYYY".
   // __TIME__ is exactly "hh:mm:ss".
+#if !defined(DONT_EMBED_BUILD_METADATA)

[rvargas (doing something else), 2014/10/16 22:32:07]

nit: invert the order of the if (#if defined())

It would be nice to use an affirmative value for the definition itself (instead
of DONT_), especially if most of the time the code ends up having #if and #else
paths

[Sébastien Marchand, 2014/10/17 13:51:11]

Done.

We shouldn't use this macro that much, but I'll try to find another name for it.

   const char kDateTime[] = __DATE__ " " __TIME__ " PST";
+#else
+  const char kDateTime[] = "Sep 02 2008 08:00:00 PST";
+#endif
   bool result = Time::FromString(kDateTime, &integral_build_time);
   DCHECK(result);
   return integral_build_time;