Issue 660733003: [turbofan] Run value numbering after SimplifiedLowering.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 660733003: [turbofan] Run value numbering after SimplifiedLowering. (Closed)

Created:
6 years, 2 months ago by Benedikt Meurer

Modified:
6 years, 2 months ago

Reviewers:
Jarin

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

[turbofan] Run value numbering after SimplifiedLowering. Running ValueNumberingReducer together with ChangeLowering causes trouble with the current GraphReducer and makes GVN ineffective, so running it before we get to change lowering works around that well-known (phase ordering) problem for now. R=jarin@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24656

Patch Set 1 #

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -2 lines)			Patch
	M	src/compiler/pipeline.cc	View		2 chunks	+6 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Benedikt Meurer

6 years, 2 months ago (2014-10-16 10:50:30 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 24656 (presubmit successful).

Expand Messages | Collapse Messages