Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issue 66073003: Refine CopyBytes macro instruction in IA32/X64 (Closed)

Created:
7 years, 1 month ago by Weiliang
Modified:
7 years, 1 month ago
Reviewers:
Sven Panne
CC:
v8-dev
Base URL:
git://github.com/v8/v8.git@master
Visibility:
Public.

Description

Refine CopyBytes macro instruction in IA32/X64 Use DWORD/QWORD copy for more short cases BUG= R=svenpanne@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=17632

Patch Set 1 #

Patch Set 2 : X64 port #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -20 lines) Patch
M src/ia32/macro-assembler-ia32.cc View 1 1 chunk +25 lines, -7 lines 0 comments Download
M src/x64/macro-assembler-x64.cc View 1 2 chunks +35 lines, -13 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Weiliang
It improves the array.join by 30% for short cases and less than 1% regression for ...
7 years, 1 month ago (2013-11-08 08:10:52 UTC) #1
Weiliang
port to x64
7 years, 1 month ago (2013-11-09 14:33:20 UTC) #2
Sven Panne
LGTM, I'll land it for you. Duff's device reloaded in assembler, well, almost... ;-)
7 years, 1 month ago (2013-11-12 08:07:13 UTC) #3
Sven Panne
7 years, 1 month ago (2013-11-12 09:08:59 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r17632 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698