Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(414)

Issue 66073: Makes the omnibox show past searches and suggestions for keywords.... (Closed)

Created:
11 years, 8 months ago by sky
Modified:
9 years, 7 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Makes the omnibox show past searches and suggestions for keywords. We talked about primary and secondary, but after doing it all I felt keyword and default better portrayed what is going on. After trying this out I think we need to tune relevancy. But that can be done later BUG=3636 TEST=make sure omnibox isn't broken. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=13668

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 20

Patch Set 3 : '' #

Total comments: 20

Patch Set 4 : '' #

Patch Set 5 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+525 lines, -188 lines) Patch
M chrome/browser/autocomplete/autocomplete.h View 3 4 2 chunks +41 lines, -20 lines 0 comments Download
M chrome/browser/autocomplete/autocomplete_popup_model.cc View 3 4 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/autocomplete/keyword_provider.h View 1 2 3 4 2 chunks +18 lines, -1 line 0 comments Download
M chrome/browser/autocomplete/keyword_provider.cc View 1 2 3 4 4 chunks +35 lines, -9 lines 0 comments Download
M chrome/browser/autocomplete/search_provider.h View 1 2 3 4 6 chunks +147 lines, -29 lines 0 comments Download
M chrome/browser/autocomplete/search_provider.cc View 1 2 3 4 23 chunks +271 lines, -122 lines 0 comments Download
M chrome/browser/importer/importer.cc View 3 4 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/search_engines/template_url.h View 3 4 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/search_engines/template_url.cc View 3 4 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/views/keyword_editor_view.cc View 3 4 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
sky
11 years, 8 months ago (2009-04-11 03:21:16 UTC) #1
Peter Kasting
This is generally good stuff. Two substantive change suggestions: * Rather than have the default ...
11 years, 8 months ago (2009-04-13 14:06:46 UTC) #2
sky
New snapshot uploaded. http://codereview.chromium.org/66073/diff/10/1002 File chrome/browser/autocomplete/keyword_provider.cc (right): http://codereview.chromium.org/66073/diff/10/1002#newcode133 Line 133: matches_.push_back(CreateAutocompleteMatch(model, keyword, input, On 2009/04/13 ...
11 years, 8 months ago (2009-04-13 23:07:24 UTC) #3
Peter Kasting
http://codereview.chromium.org/66073/diff/10/1002 File chrome/browser/autocomplete/keyword_provider.cc (right): http://codereview.chromium.org/66073/diff/10/1002#newcode133 Line 133: matches_.push_back(CreateAutocompleteMatch(model, keyword, input, On 2009/04/13 23:07:24, sky wrote: ...
11 years, 8 months ago (2009-04-13 23:42:24 UTC) #4
sky
New snapshot uploaded. I didn't change a couple of things (as noted below). If you ...
11 years, 8 months ago (2009-04-14 03:59:09 UTC) #5
sky
New snapshot is really up now.
11 years, 8 months ago (2009-04-14 04:08:48 UTC) #6
Peter Kasting
http://codereview.chromium.org/66073/diff/2002/2007 File chrome/browser/autocomplete/autocomplete.h (right): http://codereview.chromium.org/66073/diff/2002/2007#newcode138 Line 138: // keyword, then the primary provider corresponds to ...
11 years, 8 months ago (2009-04-14 04:33:22 UTC) #7
sky
I've updated the patch as we discussed: the lower limit of 275 has been nuked.
11 years, 8 months ago (2009-04-14 16:47:23 UTC) #8
Peter Kasting
11 years, 8 months ago (2009-04-14 16:48:50 UTC) #9
LGTM, let's start testing it!

Powered by Google App Engine
This is Rietveld 408576698