Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(378)

Issue 660723005: mac: Remove a spamming error message. (Closed)

Created:
6 years, 2 months ago by erikchen
Modified:
6 years, 2 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

mac: Remove a spamming error message. The error message is "ERROR:location_bar_view_mac.mm(592)] Not implemented reached in virtual void LocationBarViewMac::EndOriginChipAnimations(bool)". It's been spamming for months, so it can't be that important. BUG=408366 Committed: https://crrev.com/fde4714574d7c7c7f87620e7735c4bcf474df2ec Cr-Commit-Position: refs/heads/master@{#300035}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
erikchen
pkasting: Please review.
6 years, 2 months ago (2014-10-16 23:33:57 UTC) #2
Peter Kasting
I pinged the origin chip list in hopes of getting approval to rip out the ...
6 years, 2 months ago (2014-10-16 23:41:14 UTC) #3
Peter Kasting
Well that was fast. Origin chip is officially dead. So go for it. LGTM
6 years, 2 months ago (2014-10-16 23:45:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/660723005/1
6 years, 2 months ago (2014-10-16 23:52:01 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-17 01:21:16 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-10-17 01:22:24 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fde4714574d7c7c7f87620e7735c4bcf474df2ec
Cr-Commit-Position: refs/heads/master@{#300035}

Powered by Google App Engine
This is Rietveld 408576698