MemoryCache: Remove ENABLE(ASSERT) checks for readability

MemoryCache: Remove ENABLE(ASSERT) checks for readability

There is no behavioral change.

BUG=n/a
TEST=should pass all existing tests

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183794

[nhiroki, 2014-10-16 06:26:26]

nhiroki@chromium.org changed reviewers:
+ mkwst@chromium.org

[nhiroki, 2014-10-16 06:26:54]

Hi Mike, could you review this?

[Mike West, 2014-10-16 06:34:46]

LGTM % comments.

https://codereview.chromium.org/660723002/diff/1/Source/core/fetch/MemoryCach...
File Source/core/fetch/MemoryCache.cpp (right):

https://codereview.chromium.org/660723002/diff/1/Source/core/fetch/MemoryCach...
Source/core/fetch/MemoryCache.cpp:407: ASSERT(containsInLRUList(entry, list));
This is a huge improvement, thank you.

https://codereview.chromium.org/660723002/diff/1/Source/core/fetch/MemoryCache.h
File Source/core/fetch/MemoryCache.h (right):

https://codereview.chromium.org/660723002/diff/1/Source/core/fetch/MemoryCach...
Source/core/fetch/MemoryCache.h:237: bool containsInLRUList(MemoryCacheEntry*,
MemoryCacheLRUList*);
Nit: Either "containedInLRUList" or "LRUListContains" would be more gramatically
correct.

https://codereview.chromium.org/660723002/diff/1/Source/core/fetch/MemoryCach...
Source/core/fetch/MemoryCache.h:242: bool
containsInLiveDecodedResourcesList(MemoryCacheEntry*);
Nit: Same comment.

[nhiroki, 2014-10-16 07:37:55]

Thank you for reviewing. Updated.

https://codereview.chromium.org/660723002/diff/1/Source/core/fetch/MemoryCache.h
File Source/core/fetch/MemoryCache.h (right):

https://codereview.chromium.org/660723002/diff/1/Source/core/fetch/MemoryCach...
Source/core/fetch/MemoryCache.h:237: bool containsInLRUList(MemoryCacheEntry*,
MemoryCacheLRUList*);
On 2014/10/16 06:34:46, Mike West wrote:
> Nit: Either "containedInLRUList" or "LRUListContains" would be more
gramatically
> correct.

Done.

https://codereview.chromium.org/660723002/diff/1/Source/core/fetch/MemoryCach...
Source/core/fetch/MemoryCache.h:242: bool
containsInLiveDecodedResourcesList(MemoryCacheEntry*);
On 2014/10/16 06:34:46, Mike West wrote:
> Nit: Same comment.

Done.

[nhiroki, 2014-10-16 07:37:59]

The CQ bit was checked by nhiroki@chromium.org

[commit-bot: I haz the power, 2014-10-16 07:38:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/660723002/20001

[commit-bot: I haz the power, 2014-10-16 08:50:57]

Committed patchset #2 (id:20001) as 183794