Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 660683002: Adds Cast on Android as a valid tracing configuration (chromecast_shell). (Closed)

Created:
6 years, 2 months ago by gunsch
Modified:
6 years, 2 months ago
Reviewers:
klundberg, jbudorick
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, lcwu1, byungchul, bulach
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Adds Cast on Android as a valid tracing configuration (chromecast_shell). R=bulach@chromium.org BUG= Committed: https://crrev.com/7547f25c856d4c2f9ccf4ec65ac96c39b1229cad Cr-Commit-Position: refs/heads/master@{#299907}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M build/android/pylib/constants.py View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
gunsch
6 years, 2 months ago (2014-10-16 00:26:53 UTC) #1
klundberg
- bulach as he has left the Chrome team + jbudorick who now owns pylib
6 years, 2 months ago (2014-10-16 03:31:38 UTC) #3
jbudorick
lgtm
6 years, 2 months ago (2014-10-16 08:12:24 UTC) #4
gunsch
Thanks, I was looking at an old OWNERS file.
6 years, 2 months ago (2014-10-16 16:00:12 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/660683002/1
6 years, 2 months ago (2014-10-16 16:00:41 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu_triggered_tests/builds/69161)
6 years, 2 months ago (2014-10-16 16:37:08 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/660683002/1
6 years, 2 months ago (2014-10-16 16:41:44 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-16 17:18:56 UTC) #12
commit-bot: I haz the power
6 years, 2 months ago (2014-10-16 17:19:28 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7547f25c856d4c2f9ccf4ec65ac96c39b1229cad
Cr-Commit-Position: refs/heads/master@{#299907}

Powered by Google App Engine
This is Rietveld 408576698