Introduce CdmFactory interface.

content/renderer/media/crypto/render_cdm_factory.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#ifndef CONTENT_RENDERER_MEDIA_CRYPTO_CONTENT_DECRYPTION_MODULE_FACTORY_H_
-#define CONTENT_RENDERER_MEDIA_CRYPTO_CONTENT_DECRYPTION_MODULE_FACTORY_H_
+#ifndef CONTENT_RENDERER_MEDIA_CRYPTO_RENDER_CDM_FACTORY_H_
+#define CONTENT_RENDERER_MEDIA_CRYPTO_RENDER_CDM_FACTORY_H_
 
 #include <string>
 
 #include "base/memory/scoped_ptr.h"
+#include "media/base/cdm_factory.h"
 #include "media/base/media_keys.h"
 
 #if defined(ENABLE_PEPPER_CDMS)
 #include "content/renderer/media/crypto/pepper_cdm_wrapper.h"
 #endif
 
 class GURL;
 
 namespace content {
 
 #if defined(ENABLE_BROWSER_CDMS)
 class RendererCdmManager;
 #endif
 
-class ContentDecryptionModuleFactory {
+class RenderCdmFactory : public media::CdmFactory {
  public:
-  // |create_pepper_cdm_cb| will be called synchronously if necessary. The other
-  // callbacks can be called asynchronously.
-  static scoped_ptr<media::MediaKeys> Create(
+#if defined(ENABLE_PEPPER_CDMS)
+  explicit RenderCdmFactory(const CreatePepperCdmCB& create_pepper_cdm_cb);
+#elif defined(ENABLE_BROWSER_CDMS)
+  explicit RenderCdmFactory(RendererCdmManager* manager);
+#else
+  RenderCdmFactory();
+#endif  // defined(ENABLE_PEPPER_CDMS)
+
+  virtual ~RenderCdmFactory();
+
+  virtual scoped_ptr<media::MediaKeys> Create(
       const std::string& key_system,
       const GURL& security_origin,
-#if defined(ENABLE_PEPPER_CDMS)
-      const CreatePepperCdmCB& create_pepper_cdm_cb,
-#elif defined(ENABLE_BROWSER_CDMS)
-      RendererCdmManager* manager,
-      int* cdm_id,  // Output parameter indicating the CDM ID of the MediaKeys.
-#endif  // defined(ENABLE_PEPPER_CDMS)
+#if defined(ENABLE_BROWSER_CDMS)
+      int* cdm_id,
+#endif
       const media::SessionMessageCB& session_message_cb,
       const media::SessionReadyCB& session_ready_cb,
       const media::SessionClosedCB& session_closed_cb,
       const media::SessionErrorCB& session_error_cb,
       const media::SessionKeysChangeCB& session_keys_change_cb,
-      const media::SessionExpirationUpdateCB& session_expiration_update_cb);
+      const media::SessionExpirationUpdateCB& session_expiration_update_cb)
+      const override;
+
+ private:
+#if defined(ENABLE_PEPPER_CDMS)
+  const CreatePepperCdmCB create_pepper_cdm_cb_;
+#elif defined(ENABLE_BROWSER_CDMS)
+  RendererCdmManager* const manager_;

[ddorwin, 2014/10/17 01:41:55]

This is technically correct and will compile, but it's misleading and generally
discouraged to have access a modifiable object from a const function.

[xhwang, 2014/10/17 03:54:21]

Done.

+#endif
+
+  DISALLOW_COPY_AND_ASSIGN(RenderCdmFactory);
 };
 
 }  // namespace content
 
-#endif  // CONTENT_RENDERER_MEDIA_CRYPTO_CONTENT_DECRYPTION_MODULE_FACTORY_H_
+#endif  // CONTENT_RENDERER_MEDIA_CRYPTO_RENDER_CDM_FACTORY_H_