Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issue 660663003: Use scoped_ptr::Pass instead of scoped_ptr::PassAs<T>. (Closed)

Created:
6 years, 2 months ago by dcheng
Modified:
6 years, 2 months ago
Reviewers:
stevenjb, satorux1
CC:
chromium-reviews, hashimoto+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Use scoped_ptr::Pass instead of scoped_ptr::PassAs<T>. BUG=423621 Committed: https://crrev.com/b92d87bee7689009c26be560634070a33508bcaf Cr-Commit-Position: refs/heads/master@{#299949}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -65 lines) Patch
M chromeos/cryptohome/homedir_methods_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/dbus/bluetooth_agent_service_provider.cc View 3 chunks +12 lines, -24 lines 0 comments Download
M chromeos/dbus/bluetooth_gatt_characteristic_service_provider.cc View 10 chunks +12 lines, -12 lines 0 comments Download
M chromeos/dbus/bluetooth_gatt_descriptor_service_provider.cc View 10 chunks +12 lines, -12 lines 0 comments Download
M chromeos/dbus/bluetooth_gatt_service_service_provider.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M chromeos/dbus/bluetooth_profile_service_provider.cc View 1 chunk +4 lines, -8 lines 0 comments Download
M chromeos/network/onc/onc_merger.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
dcheng
6 years, 2 months ago (2014-10-16 03:31:19 UTC) #2
dcheng
+stevenjb
6 years, 2 months ago (2014-10-16 18:01:16 UTC) #4
stevenjb
lgtm
6 years, 2 months ago (2014-10-16 18:32:25 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/660663003/1
6 years, 2 months ago (2014-10-16 18:34:40 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-16 19:16:13 UTC) #8
commit-bot: I haz the power
6 years, 2 months ago (2014-10-16 19:18:01 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b92d87bee7689009c26be560634070a33508bcaf
Cr-Commit-Position: refs/heads/master@{#299949}

Powered by Google App Engine
This is Rietveld 408576698